mail
2019-03-01 11:40
hello everyone! I'm currently evaluating Pact for use with services written in PHP, and I'm wondering if you know of/have tested alternative approaches to setting the provider state, other than the expose-a-custom-endpoint approach?
arunkumarpoonia
2019-03-21 17:13
I am unable to build interaction without given, more details - https://github.com/pact-foundation/pact-php/issues/117
detert
2019-05-07 12:44
Hi there. I currently try to implement pact with php. I use `https://github.com/pact-foundation/pact-mock-service-docker` as mock service and I have a running customer test. However I am not able to create a pact file that shall be send to the pact broker. What do I miss? Do I miss something at `https://github.com/pact-foundation/pact-php/`?
detert
2019-05-13 10:25
I try to run `verifyAll()` in a provider test in order to validate all customer contracts. However I do not really understand how to set the provider state before each verifyAction. Is `https://github.com/pact-foundation/pact-php/blob/master/example/tests/MessageProvider/ExampleMessageProviderTest.php` the correct documentation for that? Something tries to create a server, but I just want to set the state of my database for each contract
matt.fellows
2019-05-13 11:21
That looks to be an example for a message provider - are you testing HTTP interactions or async/messages?
detert
2019-05-13 11:27
HTTP interactions, but I could not find any example to set up a provider state
matt.fellows
2019-05-13 11:37
Have you looked at this example https://github.com/mattermack/pact-php-example/blob/master/example-api/test/ExampleApiServerTest.php ?
matt.fellows
2019-05-13 11:40
At the moment (at least in Pact PHP it seems) you?ll need to add a dynamic endpoint during test to receive the state request and update the state
matt.fellows
2019-05-13 21:10
nicely done! Might be worth raising an issue to have the docs make this clearer on the main README
detert
2019-05-14 06:11
yeah maybe. I'll integrate everything into gitlab first. I can make good suggestions then hopefully
braddle
2019-05-16 12:50
Ignore this i think I was mixing up errors in my code. Was trying to improve the output i was getting when my tests failed.
detert
2019-05-17 08:23
when do you publish the results of the provider verifications? Before or after the provider was released?
bethskurrie
2019-05-17 08:32
You tag the provider version as prod when you release, but the results should be published when you run the verification step, just after your provider unit tests.
detert
2019-05-17 08:39
I see. Do you know any document with a timeline or something, where I can see the order of events as best practice?
bethskurrie
2019-05-17 08:45
I can't seem to get to it on my phone, but if you go to http://docs.pact.io and find the Effective Pact Setup Guide under the Best Practises section, that will give you a step by step set of instructions for setting up your pipeline.
detert
2019-05-21 06:32
I have another question. The docs mention Symfony. Is there a simple was to implement `PhpPact\Standalone\ProviderVerifier::verifiyAll()` without Nginx? I would like to use the abilities of `Symfony\Bundle\FrameworkBundle\Test\WebTestCase` as I have no Nginx running in my CI pipeline currently
detert
2019-05-28 12:30
When I run the provider verification tests with verifyAll and those tests fail, all I receive is an Exception stating "Exception: PactPHP Process returned non-zero exit code: 1". Is there any way to get a better error message? A link to the pact-broker like `https://pact-broker.local/hal-browser/browser.html#/pacts/provider/myprovider/consumer/myconsumer/pact-version/2835ae83c9b6d1328c73110fca62e7e1c2deb01f/verification-results/106` would help, the complete Response body would be perfect
matt.fellows
2019-05-28 12:31
I?m not close to the PHP implementation, but others that use the same underlying library (e.g. JS and Go) print out the specific issues
detert
2019-05-28 12:33
I can only use $e->getMessage(), that is just the provided string. However, I see that some logger is used to add more details, maybe I am able to find out how that works
pact.io
2019-05-28 19:07
~<@U9UUY3CU9> I am able to reproduce the problem, however I am not able to write a good test for it. The output of `pact-provider-verifier` seems to confuse the `Amp\Process\Process`. If I run it, the output is not captured completely. However I am not able to find a simpler cmd, that could "make my test red" in the first place. Any ideas?~
pact.io
2019-05-28 20:34
@matt.fellows I added a pull request to my earlier problem (missing error logs)
pact.io
2019-05-30 13:26
Does someone use pact-php with windows? I am not able to run the tests properly
```
.\vendor\bin\phpunit.bat --debug -c .\example\phpunit.all.xml --filter testBlockingProcess
PHPUnit 7.5.12 by Sebastian Bergmann and contributors.
Test 'PhpPact\Standalone\Runner\ProcessRunnerTest::testBlockingProcess' started
[2019-05-30 12:26:11] server.debug: Process command: dir [] []
Test 'PhpPact\Standalone\Runner\ProcessRunnerTest::testBlockingProcess' ended
Time: 24.31 minutes, Memory: 6.00 MB
There was 1 error:
1) PhpPact\Standalone\Runner\ProcessRunnerTest::testBlockingProcess
Amp\Process\ProcessException: Failed to create child process: 2: Das System kann die angegebene Datei nicht finden.
F:\windows\pact-php\vendor\amphp\process\lib\Internal\Windows\SocketConnector.php:344
F:\windows\pact-php\vendor\amphp\amp\lib\Loop\NativeDriver.php:130
F:\windows\pact-php\vendor\amphp\amp\lib\Loop\Driver.php:134
F:\windows\pact-php\vendor\amphp\amp\lib\Loop\Driver.php:72
F:\windows\pact-php\vendor\amphp\amp\lib\Loop.php:84
F:\windows\pact-php\src\PhpPact\Standalone\Runner\ProcessRunner.php:159
F:\windows\pact-php\src\PhpPact\Standalone\Runner\ProcessRunner.php:100
F:\windows\pact-php\tests\PhpPact\Standalone\Runner\ProcessRunnerTest.php:22
ERRORS!
Tests: 1, Assertions: 0, Errors: 1.
```
pact.io
2019-05-30 13:27
Following the source code, it looks like a timeout. I tried to increase the timeout from 1000 to 100000, it did not help
pact.io
2019-06-11 16:59
Is the todo list in https://github.com/pact-foundation/pact-php/issues/29 up to date? What is most important? I think about contributing a bit more
marco
2020-01-14 14:18
Hi guys,
What is the process to update the pact binaries? I want to be able to add a tag to my provider version which requires a newer pact-provider-verifier standalone.
marco
2020-01-14 17:14
Could someone help me with this failing test? I can't find out what's going wrong...
matt.fellows
2020-01-14 19:44
If it?s not obvious on the Pact PHP github page, perhaps raise a ticket showing the problem and/or put together a PR with your suggestion
matt.fellows
2020-01-14 19:45
There is possibly a reference in the installation code somewhere that pulls it down
marco
2020-01-14 21:14
Oh, sorry. I was referring to the merge request in the message above (https://github.com/pact-foundation/pact-php/pull/143).
This is the build output: https://travis-ci.org/pact-foundation/pact-php/jobs/637005496?utm_medium=notification&utm_source=github_status
marco
2020-01-14 21:18
I don't have experience with the message validation and it seems to go wrong there. I digged in to it but can't really wrap my head around what's going wrong :sweat_smile:
matt.fellows
2020-01-14 21:18
Had a quick look. It looks like the verification (or the test) is hitting a webserver, which I?m not sure is the correct behaviour in a message verification test.
marco
2020-01-14 21:19
That would be awesome, meanwhile I'll get some sleep and maybe a fresh mind will do wonders tomorrow morning. Thanks for now!
cfmack
2020-01-15 02:32
Howdy y'all. It appears the only thing that was materially updated was a big jump in the Ruby version. I bet if we get real deep, something changed there, either an API, a new parameter, something.
There is actually a request to add logging of Ruby to the PHP configurations. I.e. when calling Ruby, log at the debug level. If you want to put in a PR for https://github.com/pact-foundation/pact-php/issues/109 it may help :slightly_smiling_face:
cfmack
2020-01-15 02:48
@matt.fellows I'm honest, I had to google a "squiz". Not a Texas saying ... yet. I may make it one.
cfmack
2020-01-15 03:33
@bethskurrie, I got weird one here. Between stand alone 1.60.0 and 1.60.1, pact message broker stopped putting provider states array into the message provider states array. I'll put in an issue to see if I can articulate it better.
matt.fellows
2020-01-15 03:53
I think that?s quite an old version - have you tried with latest? Or is that just your debugging finding the cause of the issue?
cfmack
2020-01-15 04:07
https://github.com/pact-foundation/pact-ruby-standalone/issues/43
I know I know I'm on a old version. Been meaning on updating it sooner. What can I say, I like the classics :slightly_smiling_face:. All good if you can take a peek. May be @marco can provider a stand alone example. Yes, I definitely need to update the version!
matt.fellows
2020-01-15 08:35
@cfmack speaking of Pact PHP... https://twitter.com/braddle/status/1217352901435314177?s=19
marco
2020-01-15 12:27
Thanks so much for helping already! I'll try to get an example after work today, tried in between meetings but need some focus time to wrap my head around the workings :sweat_smile:
marco
2020-01-15 18:47
Yeey, found an easy way to reproduce, documented it as a comment on the issue:
https://github.com/pact-foundation/pact-ruby-standalone/issues/43#issuecomment-574797605
bethskurrie
2020-01-16 05:17
@cfmack I just realised I commented on the repro issue, not your original one.
cfmack
2020-01-16 05:19
All good. I think I got around to it. The code is in a POC state. There are use cases in Message that I am unsure of how we are supposed to handle ... but the original code did not handle them anyways, for better or worse.
bethskurrie
2020-01-16 05:20
I'm currently in message pact headspace, because I'm writing the ruby verification dsl
cfmack
2020-01-16 05:21
the crux is with the PHP implementation, I have no idea what do do with the params
cfmack
2020-01-16 05:22
Are we supposed to use the params to set the provider state? (typing this out as I stare into the void)
bethskurrie
2020-01-16 05:22
As in, you don't get what they're for, or you don't know how to make the code handle them?
bethskurrie
2020-01-16 05:23
So, the code that sets up the provider states should be passed the params
cfmack
2020-01-16 05:23
I think in the case of message broker, I actually need multiple call backs to get this to work
bethskurrie
2020-01-16 05:23
I know it'll look completely diff in php, but in ruby it goes like:
```Pact.provider_states_for "Foo" do
provider_state "a world exists" do
set_up do | params |
DataStore.greeting_recipient = params[:name]
end
end
end```
bethskurrie
2020-01-16 05:24
I'm thinking that we should change the callback to allow just one call for all the states together.
bethskurrie
2020-01-16 05:24
Because sometimes there are dependencies between them that you need to set up, so you want the context from the previous state.
cfmack
2020-01-16 05:26
I should just require params to be passed into the callback with the pact json
bethskurrie
2020-01-16 05:27
Also, here's the javascript example: https://github.com/pact-foundation/pact-js#provider-producer
cfmack
2020-01-16 05:27
In the case where I have multiple messages in a single pact, I maintain a list of callbacks for all messages at once. Right now, those are keyed by providerState ... when they should be keyed by description
bethskurrie
2020-01-16 05:27
I can't see how that handles provider states, so you'll have to ask Matt.
bethskurrie
2020-01-16 05:28
```CONFIG = {
"a message" => lambda { BarProvider.new.create_message }
}
MESSAGE_INVOKER = lambda { |description| CONFIG[description].call }```
cfmack
2020-01-16 05:29
In the original implementation, for reasons I do not recall, I only allowed one state per callback ... which is just silly
bethskurrie
2020-01-16 05:31
Thanks! Looking forward to being able to go outside and breathing clean air sometime in the future...
marco
2020-01-16 13:05
Thank you guys so much for helping!
I posted a response to the issue (https://github.com/pact-foundation/pact-php/pull/143#issuecomment-575140757) tried to pass the params into the callback but running into issues there as well...
marco
2020-01-21 08:16
@cfmack do you maybe have some time to check out my latest comment to the issue :slightly_smiling_face:?
matt.fellows
2020-01-21 12:16
marco
2020-01-22 19:05
Thanks, I'm flying out tomorrow for a quick holiday so will not be online for the next days. :disappointed:
angelo
2020-07-20 09:57
Hi! We're using pact-js (v9.11) for consumer side and pact-php (v5.0) for provider side. Is there a way to have WIP pacts activated using the php library for the provider side? Ive seen in the github issues that's its yet to be implemented and I wonder if there's a workaround? (edited)
matt.fellows
2020-07-20 10:18
Yes. I haven't looked at the PHP verifier but the flags should be really easy to add
matt.fellows
2020-07-20 10:19
It just wraps the Ruby standalone verifier (bundled with Pact PHP), so if you're not doing anything fancy you could just invoke it directly and enable Wip pacts until the flag is added
matt.fellows
2020-07-20 10:19
You also need to enable it on your broker if you're self hosting (enabled on Pactflow accts by default)
matt.fellows
2020-07-20 10:20
Just out and about but if none of that makes sense let me know and when I'm back at my desk o can clear it up :grinning:
tien.xuan.vo
2020-07-21 10:59
@matt.fellows I'm here already. Please show us how to maintain this project
angelo
2020-07-30 04:58
is there a way to publish verification results with tags (read the docs saw nothing about it)? Currently I'm doing it after publishing to broker I run the dockerized cli to add tags and having problems with the webhook since it triggers without a tag so slack notifs have incomplete info
sschectman
2020-08-04 16:18
Getting this error after installing pact : Fatal error: Uncaught Error: Class 'PhpPact\Standalone\MockService\MockServerConfig' not found
sschectman
2020-08-07 20:25
I have pact directory set in config but pact file is not being generated, can someone advise?
angelo
2020-08-11 06:26
using laravel 5.5 atm to run the provider tests. I tried using trait RefreshDatabase in my test file but in only works between tests and pact provider verification only runs in one test function so db doesnt actually reset. Is there a way of using RefreshDatabase inside your controller or an alternative method?
angelo
2020-08-11 10:35
nevermind solved it by running the facade artisan migrate:fresh inside the state setup endpoint.
os.shulyak
2020-08-17 10:51
hey there.
I?m trying it implement PACT messages in php with this example https://github.com/pact-foundation/pact-php#message-support , but i?ve got the error with using of `ExampleMessageProvider` class, and the error looks like this:
```Error : Class 'MessageProvider\ExampleMessageProvider' not found```
and this is the namespace that i use:
```use MessageProvider\ExampleMessageProvider;```
For now, have no idea how to fix that..
heytaco
2020-08-25 03:57
Hi there! My name is HeyTaco!, and you can use me to give people tacos to show your appreciation. My tacos will spread joy through Slack!
pavel.azarau
2020-11-06 21:59
hello folks. Haven?t found this info in a channel. Is there a way to configure multiple providers for consumer via phpunit.xml?
pavel.azarau
2020-11-06 22:01
I see an example
```<php>
<env name="PACT_CONSUMER_NAME" value="Some_consumer"/>
<env name="PACT_CONSUMER_VERSION" value="1.0.0"/>
<env name="PACT_CONSUMER_TAG" value="sometag"/>
<env name="PACT_PROVIDER_NAME" value="somename"/>
</php>```
but what if I need few providers?
mailinglistsspammedme
2021-01-28 23:59
Question about Pact-php:
https://pact-foundation.slack.com/archives/C5F4KFKR8/p1611877103086900
matt.fellows
2021-01-29 00:08
can you please elaborate on the ?hard coding?? Perhaps that can be made more dynamic
mailinglistsspammedme
2021-01-29 00:11
PHPUnit has this concept of a "Test Suite" which is a grouping of tests. This is an _optional_ construct, and you can also just run random folders separately which doesn't have a test suite.
mailinglistsspammedme
2021-01-29 00:12
The way that listener works, it requires a named test suite to be listed in it's configuration, so if you just run 'all tests' in your IDE, or you run some sub folder, that listener never fires.
mailinglistsspammedme
2021-01-29 00:12
Because of this code:
``` if (\in_array($suite->getName(), $this->testSuiteNames)) {
$this->server = new MockServer($this->mockServerConfig);
$this->server->start();
}```
mailinglistsspammedme
2021-01-29 00:14
So I can just use the other instructions for starting the Mock Server in this case, however then my CI breaks for when we should actually publish the pacts.
matt.fellows
2021-01-29 01:56
I see. I roughly understand, it?s probably worth raising a feature request via Github
ktogias
2021-04-01 20:26
Hello. I try to verify my provider with PACT-PHP, but verifier does not seem to take into account the match type (like and eachLike) matchingRules. Test will succeed only when the actual pact response body is returned. When I change a value eg. 'id': 345 instead of 'id': 123 the provider test fails, although pact file has matchingRules like
```"$.body[*].id": {
"match": "type"
}```
Am I missing something? Shouldn't the verifier check only for the type of the responce objects?
ktogias
2021-04-01 20:33
My PACT as shown in pact borker HAL Browser is this: https://pastebin.com/05LvhW00
ktogias
2021-04-01 20:33
A provider returning the same objects with different numeric ids fail to validate it with pact php. If all values are exactly the same it validates.
matt.fellows
2021-04-02 12:23
It looks like a v3 generated pact, so it's possible it's not reading the matchers. What language are you using to generate the provider? If you can serialise a V2 pact that might help
ktogias
2021-04-02 12:26
The provider is on php. The pact file is generated with pact-js and jest from a javascript client.
matt.fellows
2021-04-02 22:35
The matchers look like V2 ones, but the spec says three. How'd you generate it?
matt.fellows
2021-04-02 22:36
You could use the generic CLI verifier: https://docs.pact.io/implementation_guides/cli/
matt.fellows
2021-04-06 13:27
The beta version? I ask because I'm confused about the spec version in the file. You haven't modified afterwards?
github
2021-04-19 00:57
GitHub app is successfully upgraded in your workspace :tada:
To receive notifications in your private channels, you need to invite the GitHub app `/invite @GitHub`
tien.xuan.vo
2021-04-23 02:17
I'm learning to use pact in PHP with FFI https://github.com/tienvx/pact-reference/tree/add-php/php. I have some questions with pact messages:
? To verify that consumer is able to handle a message, how I can trigger a message handler in consumer using Pact Mock Server FFI?
? To verify that provider is able to produce a message, Pact Verifier FFI made a `POST /` then compare response to the message's contents. Is that how Pact Verifier FFI supposed to work?
matt.fellows
2021-04-23 11:33
1. You can?t actually do that via the FFI bindings, you?ll need to construct the pact interface first, extract out the values (sans matchers) and then pass the payload to the function in the PHP code itself. If the PHP code doesn?t fail, then you can serialise the pact file. I?d show you a Go example, but it?s a bit of a mess. See also https://github.com/pact-foundation/pact-message-demo (that was the Ruby design, but some of the principles apply)
2. On the provider side. You?ll need to stand up an HTTP endpoint on behalf of the provider, and when the verifier does it?s thing you map the interaction description to a registered PHP function (aka the producer) that returns its payload. The proxy returns this back to the verifier to check that the producer function was able to create the correct message
tien.xuan.vo
2021-04-25 02:00
Thank @matt.fellows. I didn't get all ideas here. I will take a look at that repository and ask more questions later (I don't know Ruby but I will try)
matt.fellows
2021-04-25 02:43
You don't need to know Ruby, just that it's how it works today interfacing to Ruby via CLI calls
matt.fellows
2021-05-29 22:50
@tien.xuan.vo :wave: how is the rust integration going? We?ve made a few changes to the FFI interface recently, my aim is to get some docs / guidance on that published next week.
tien.xuan.vo
2021-05-30 08:10
Hi, I am stuck with the segmentation fault error. And I don't know what happen and how to resolve it yet. One good news is pact-reference fixed this issue https://github.com/pact-foundation/pact-php/issues/162
tien.xuan.vo
2021-06-02 03:04
There is still one segmentation fault with `with_body`https://github.com/tienvx/pact-reference/blob/add-php/php/src/consumer-1/matches.php#L17
matt.fellows
2021-06-02 03:10
I also note you?re not using the handle based interface - that means you?re creating the pact by hand? Or is that a #TODO ?
tien.xuan.vo
2021-06-02 03:13
> I also note you?re not using the handle based interface - that means you?re creating the pact by hand? Or is that a #TODO ?
matt.fellows
2021-06-02 03:18
I saw `//$pact = file_get_contents(__DIR__ . '/../../pact/consumer-1-provider.json');` and misread.
matt.fellows
2021-06-02 03:18
When is the segfault occurring? i.e. what line in your PHP script there is it failing?
tien.xuan.vo
2021-06-02 03:18
Yes, I'm following this docs https://docs.pact.io/implementation_guides/rust/pact_mock_server_ffi#pact-model-handles
I don't know other method
tien.xuan.vo
2021-06-02 03:22
I tried the suggestion here https://pact-foundation.slack.com/archives/CA2S7E6KC/p1619436401022000 but it does not work
matt.fellows
2021-06-02 03:23
It doesn?t look like you?re calling the `init` method before the test runs, this will explain some lack of output
matt.fellows
2021-06-02 03:23
something like `$ffi->init("LOG_LEVEL");` in here: https://github.com/tienvx/pact-reference/blob/add-php/php/src/consumer-1/matches.php#L10
tien.xuan.vo
2021-06-02 03:25
I tried `$ffi->init("LOG_LEVEL=debug");` but it does not print anything, then I removed the code
matt.fellows
2021-06-02 03:25
and then in your environment (e.g. a shell) you need to export the environment variable
tien.xuan.vo
2021-06-02 14:08
I got this error:
```[2021-06-02T13:59:24Z WARN pact_mock_server_ffi] description is NULL!
[2021-06-02T13:59:24Z WARN pact_mock_server_ffi] path is NULL!
[2021-06-02T13:59:24Z WARN pact_mock_server_ffi] name is NULL!
[2021-06-02T13:59:24Z WARN pact_mock_server_ffi] Ignoring header with empty or null name
Segmentation fault```
matt.fellows
2021-06-02 23:40
I?m not sure how to do that in PHP, but in go there is a c wrapper that can be used to wrap go strings into c strings
matt.fellows
2021-06-02 23:41
looks like its documented on this page: https://www.php.net/manual/en/ffi.examples-basic.php
something like ``FFI::addr(...)`` will give a pointer to the string
matt.fellows
2021-06-02 23:41
It?s probably unlikely to work just passing PHP objects about - c won?t know about them
tien.xuan.vo
2021-06-12 12:47
I found the problem: I use the wrong type in `header.h`:
It should be `uintptr_t pact;` not `unsigned int pact;`
tien.xuan.vo
2021-06-12 12:48
Do you want to merge this https://github.com/tienvx/pact-reference/tree/add-php/php into pact-reference?
tien.xuan.vo
2021-06-16 06:03
I am checking the code of pact-php, and I have some questions:
? Where do we download dynamic libraries + c's header files into? `vendor` or `/usr/local/lib`
? I think pact-reference does not provide as much features as pact-ruby-standalone provide, doesn't it? For example `can-i-deploy` tool, publish pact files, tag version
tien.xuan.vo
2021-06-16 06:57
Sorry I miss one items:
? Download to `vendor` via requiring a new php package that contains `dll` or `so` or `dylib` files
? Download to `root/pact/bin/` like current version
? Download to `/usr/local/lib`
tien.xuan.vo
2021-06-16 07:10
I think so, I saw it here, never try https://github.com/pact-foundation/pact-php/blob/master/src/PhpPact/Standalone/Installer/Service/InstallerLinux.php#L36
matt.fellows
2021-06-16 07:11
Something like is ideal, because it's contained within the installed package and hidden from the user. If it had to go into an OS lib dir it gets messier
tien.xuan.vo
2021-06-22 16:21
I have several questions.
First question: is this true for FFI?
? Each test is given a dedicated server and port, ... and improving isolation between tests.
? Pact files will be appended to during test execution
tien.xuan.vo
2021-06-22 16:22
Second question (related to above question):
? Currently each project/service have 2 environment variables: `PACT_CONSUMER_NAME` and `PACT_PROVIDER_NAME`
? Then I saw this error `ERROR pact_mock_server_ffi] unable to write the pact file: Unable to merge pacts: Can't convert interaction of type V3 Synchronous/HTTP to V3 Asynchronous/Messages`
? So do we need to split into 4 variables `PACT_HTTP_CONSUMER_NAME` , `PACT_MESSAGE_CONSUMER_NAME` , `PACT_HTTP_PROVIDER_NAME` , `PACT_MESSAGE_PROVIDER_NAME` ?
tien.xuan.vo
2021-06-23 01:51
I can edit above question so I add new one here:
> // NOTE: this must be different to the HTTP one, can't mix both interaction styles until v4
So in v4 we need to merge those variables back?
matt.fellows
2021-06-23 01:58
correct - the https://github.com/pact-foundation/pact-specification/tree/version-4 fixes that annoying problem
matt.fellows
2021-06-23 01:58
but at the moment yes, you can?t have a message interactions and http interactions in the same file
matt.fellows
2021-06-23 02:09
The v4 feature set has only just been agreed as a specification, and it is not yet fully implemented anywhere.
tien.xuan.vo
2021-06-28 16:12
Is it true that pact-php version <=7 is designed to test 1 consumer calling 1 provider only?
matt.fellows
2021-06-28 23:57
Each consumer test is only designed for a single consumer/provider, is that what you mean?
tien.xuan.vo
2021-06-29 01:32
? For each test case like this, it's designed for single consumer/provider pair, and I have no question about it:
```$config = new MockServerEnvConfig();
$builder = new InteractionBuilder($config);
$builder
->given('a person exists')
->uponReceiving('a get request to /hello/{name}')
->with($request)
->willRespondWith($response);
$service = new HttpClientService($config->getBaseUri()); // Pass in the URL to the Mock Server.
$result = $service->getHelloString('Bob');
$builder->verify();
$this->assertEquals('Hello, Bob', $result);```
? But for the whole test suite, there is only one mock server, and that mock server is designed for one consumer/provider pair https://github.com/pact-foundation/pact-php/blob/master/src/PhpPact/Consumer/Listener/PactTestListener.php#L60, consumer and provider are defined by environment variables `PACT_CONSUMER_NAME` and `PACT_PROVIDER_NAME`
? And for the whole project (many test suites), I think we can only define 1 value for those environment variables `PACT_CONSUMER_NAME` and `PACT_PROVIDER_NAME` , so we can only test single consumer/provider pair https://github.com/mattermack/pact-php-example/blob/master/example-one/test/phpunit.example.one.xml#L25
tien.xuan.vo
2021-06-29 01:37
That's why I asked whether `pact-php` version `<=7` is designed for 1 consumer/provider pair (for the whole project)
matt.fellows
2021-07-01 12:03
Sorry Tien, I missed this. What?s the example code to merge into pact reference?
tien.xuan.vo
2021-07-13 01:58
Hi @cfmack, as you can see in the room #pact-rust, Matt suggested me to contact with you to discuss about my code to update pact-php to support Pact Rust FFI.
You can see my code here https://github.com/pact-foundation/pact-php/compare/master...tienvx:rust-ffi?expand=1
I didn't create merge request because it's still a mess, and it's not green yet, still waiting for next release of Pact FFI.
Any suggestion are welcome.
aphronio
2021-07-30 13:46
can we use wiremock instead of pact standalone server? If yes then is it a good idea?
matt.fellows
2021-07-30 23:08
What are you trying to achieve? Mountebank is a great stubbing tool but doesn't do contract testing
aphronio
2021-08-02 10:55
I want to integrate contract based testing in already built microservices. So, I was wondering if there is a way to capture the requests and response from the real system instead of writing my own using pact-php request and response classes. Because I don't have proper documentation of API's and it would be a lot of work if had to define them manually for every test i create.
matt.fellows
2021-08-02 11:55
You could certainly do that, but you?d need to convert them back to a Pact file somehow. We don?t currently have that capability
matt.fellows
2021-08-02 11:55
furthermore, you?ll be missing out on adding matching rules, which means tests may be brittle for your provider when they verify it
matt.fellows
2021-08-02 11:56
Think of it this way: you?re writing _unit test_ of your code. Autogenerating unit tests is a bad idea, because now your tests aren?t having their assumptions tested properly
matt.fellows
2021-08-02 11:58
we also did an AMA on this back in April ?can I generate a test from my OAS??: https://docs.pact.io/help/amas/#ukeu
aphronio
2021-08-02 13:39
I see, I actually saw a talk where the developer was using wiremock in combination with springcloud contracts to auto generate contract files. I thought maybe it is also possible with pact to use a third party mock server because wiremock server is easier as compared to pact standalone server that comes with pact-php. Or may be i am not using it right? Thanks for your explanation and patience. I really appreciate it
matt.fellows
2021-08-03 06:37
There might be an adapter for Wiremock to convert to a Pact file, but it would be really hard to do with matching rules. Without matching rules, your Pact tests will be very painful
matt.fellows
2021-08-03 06:37
That is to say, any autogenerated pact file is likely going to be brittle to verify on the provider side with Pact
matt.fellows
2021-08-03 06:37
You could definitely do it with the Pactflow https://docs.pactflow.io/docs/workshops/bi-directional
aphronio
2021-08-03 08:35
okay I'll continue working on it. And get back to you if i have any questions. You have been very helpful in clarifying things. thanks!
sadikshahidain
2021-08-06 02:41
Using Pact for the first time (!) after being a longtime fan-at-a-distance and had a couple of (maybe dumb) questions for the consumer side in PHP I wasn't super sure about and was hoping anyone could share their insights on
? Is the right way to read the log file the Ruby mock service generates to just read it directly through PHP? (I couldn't find a helper method for this, like in analogy to "setLog"?)
? Is there a way to clear the interactions between tests? (the Ruby service's readme https://github.com/pact-foundation/pact-mock_service#mock-service-usage should be done, but I wasn't sure how to do it in my test code)
? Re: the MockServerConfig instance (which I'm setting up for now as a static variable in PHPUnit's setupBeforeClass hook)
? Both "HealthCheckTimeout" and "HealthCheckRetrySec" seem to need to be set (via their setters) in order to avoid a type error (like "...must be of the type int, null returned") when they're retrieved (the code is running on PHP 7.4 if that's relevant, as it seems this requirement was introduced in PHP 7? I'm new to PHP as well)
?? Are there specific defaults I should be setting these to?
? What does "setCors" drive here? (The ones I've written so far seem to work no matter how it's set)
Sorry for the deluge, but thank you in advance!
matt.fellows
2021-08-06 02:43
any reason why you aren?t using https://github.com/pact-foundation/pact-php/ directly?
matt.fellows
2021-08-06 02:44
> What does ?setCors? drive here? (The ones I?ve written so far seem to work no matter how it?s set)
That?s for when the mock service is being interacted with over a browser environment, that needs to respect CORS
matt.fellows
2021-08-06 02:45
But, the mock service should be cleared between interactions. If it?s not, it could be a bug in Pact PHP or a missing documentation
sadikshahidain
2021-08-06 02:47
No worries, that alone is v helpful
Ohhh, ok so that should just be automatically happening then? I thought I ran into it once when debugging after copy-pasting a test and forgetting to update the interaction, but that could've been something else now that I think about it. I'll keep an eye out for it just in case
sadikshahidain
2021-08-06 02:48
Would it be helpful to create repros for the other ones and write them as issues on Github to get feedback?
matt.fellows
2021-08-06 02:49
so it?s possible it doesn?t, but it?s also possible I?m misunderstanding the PHP usage
matt.fellows
2021-08-06 02:49
> Would it be helpful to create repros for the other ones and write them as issues on Github to get feedback?
Repros are always highly appreciated!
sadikshahidain
2021-08-06 02:50
Yeah when I skimmed it I only saw a "deleteAllInteractions" during the "finalize" step. Maybe that's what I'm missing? (since I haven't started to setup the contract parts yet?)
sadikshahidain
2021-08-06 02:51
sadikshahidain
2021-08-06 02:53
I have to drop off for today, but I'll try and spin up some isolated repros over the weekend and get those on Github to help others chime in if they can.
thank you a bunch for the speedy and helpful replies!
sadikshahidain
2021-08-09 02:18
Got Gitpod up and running for those repros, but still have to create them.
Had 1 organizational question come up in the meantime around submitting issues: If I have several smaller things related to the READme specifically, should I bundle those all in one issue, or split them into several?
matt.fellows
2021-08-09 02:19
Start with what ever is simpler and then go from there (maybe just a single one?)
sadikshahidain
2021-08-15 03:05
Oh neat this automatically showed up here. I tried to be fairly thorough but lmk if there are any additional details I should/need to add to help triage it.
I'll try to get issues/repros spun up for the things I ran into after getting the basic setup done. Top of the list for me is making the information in the log files more easily accessible in CI with the work setup, so I'll maybe focus on repro-ing that next, hopefully by next weekend at the latest.
matt.fellows
2021-08-15 03:55
Thanks! I'll take a look tomorrow. I don't maintain PHP but I'm sure your feedback will be helpful in some way
sadikshahidain
2021-08-16 23:13
For sure! Makes me feel like I'm giving back in some very small way to all your all's OSS work I and others benefit from
sadikshahidain
2021-08-23 03:00
Sorry I haven't got around to making reproductions for this yet, but if it would help I can also just add screenshots/error dumps that I ran into at work. I could get those a little faster probably.
But for any of them if it would help to have a live reproduction of just lmk and I can put one together on Gitpod (otherwise I can just wait until I hear word for them)
Thanks again for all your all's work on this extremely helpful tool!
john
2021-12-06 05:49
so the php provider what exactly does this do:
```->setRequestFilter(
function (RequestInterface $r) {
return $r->withHeader('MY_SPECIAL_HEADER', 'my special value');
}
);```
matt.fellows
2021-12-06 06:20
it looks like a request intercepter. It will intercept the request from the Pact verification process -> [your custom code] -> [provider]
matt.fellows
2021-12-06 06:20
it means you can modify the request sent to the provider. Only do this if you know what you?re doing, because you can esentially completely modify the contract here, invalidating it competely
john
2021-12-08 00:30
what version of pact php is compatible with guzzle 6.5? Nevermind i tried 6.0.3 but i get all sorts of dependency conflicts
john
2021-12-15 06:33
im getting the following error :
```
1) ProviderTest::testProvider
Error: Class 'Uri' not found
/var/www/tests/Contract/ProviderTest.php:13```
how do i fix that?
2021-12-15 06:34
Please see this page for some tips on how to ask for help to get the best response from the community https://docs.pact.io/help/how_to_ask_for_help
john
2021-12-15 06:36
im running a php app inside docker with this command:
```docker-compose run symfony composer run test:contract```
and I have the following imports :
```use PhpPact\Provider\MessageVerifier;
use PhpPact\Standalone\ProviderVerifier\Model\VerifierConfig;```
but the test run is throwing that error and i dont know why
john
2021-12-15 06:37
```->setProviderBaseUrl(new Uri('http://localhost:3000')) // URL of the Provider.```
matt.fellows
2021-12-15 06:37
If this is the example you?re using, it?s from Guzzle: https://github.com/pact-foundation/pact-php/blob/master/example/tests/Provider/PactVerifyTest.php
matt.fellows
2021-12-15 06:39
The example from github that I can see imports Uri explicitly (see link above)
matt.fellows
2021-12-15 06:39
In any case, it needs to be imported - not a PHP expert, but the error message seems pretty clear to me!
john
2021-12-15 06:40
when it says something like:
```Error: Call to undefined method PhpPact\Standalone\ProviderVerifier\Model\VerifierConfig::setRequestFilter()```
matt.fellows
2021-12-15 06:42
If it?s undefined, my assumption is that the version of Pact PHP you have doesn?t have that function on the `VerifierConfig` type
matt.fellows
2021-12-15 06:43
Looks like it?s not available until 7.x.x: https://github.com/pact-foundation/pact-php/commit/4d1bf9afee4aa91232cb220d9721ec02e7b09398
matt.fellows
2021-12-15 06:43
(that?s a commit, it may not be _the_ commit, but looks like it?s in the next major version)
john
2021-12-15 06:44
also does
```use PhpPact\Standalone\ProviderVerifier\Model\VerifierConfig;```
contain the class Verifier?
john
2021-12-15 06:47
```Testing ProviderTest
[2021-12-15 06:46:36] http://console.info: Verifying PACT with script:```
john
2021-12-15 06:48
but it returns an error:
```1) ProviderTest::testProvider
Exception: PactPHP Process returned non-zero exit code: 255```
but its ok i can maybe look at that tomorrow . at least i can run this php test which is an accomplishment - for me at least lol
john
2021-12-15 09:00
Do you think this error is related to apple M1 silicon?
```[2021-12-15 08:29:29] console.debug: Process command: /var/www/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/../../../../pact/bin/pact-provider-verifier https://fddfd.pactflow.io/pacts/provider/GraphQLProvider/consumer/GraphQLConsumer/latest/master/ --provider-base-url=http://localhost:3000 --provider-app-version=1.0.0 --publish-verification-results --enable-pending --include-wip-pacts-since=2020-01-30 [] []
[2021-12-15 08:29:29] console.debug: Exit code: 255 [] []
[2021-12-15 08:29:29] http://console.info: out > [] []
[2021-12-15 08:29:29] console.error: err > qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory```
matt.fellows
2021-12-15 09:42
Looks unrelated to M1 and more related to missing standard build tools like ld
john
2021-12-17 03:04
If i am using the php pact stuff like the above example is that using the underlying Ruby binary?
```For Pact implementations that leverage the underlying Ruby binary for their implementation, you'll need to ensure the following dependencies are met:
Bash (it's not enough to have Ash)
Standard CAs for TLS network communication
glibc```
matt.fellows
2021-12-17 03:29
Same work is going on to port to the rust shared core, but that?s in a branch
john
2021-12-17 03:45
interesting, im much more familiar with rust than php - though i normally do games development on rust and not this contract testing related stuff lol
john
2021-12-20 01:01
Im getting the following error when trying to run a provider test via docker-compose inside a php symphony app:
```console.error: err > ERROR: ld.so: object '/usr/lib/preloadable_libiconv.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.```
does anyone know what that could refer to?
john
2021-12-20 01:12
so it looks like im getting a 401 when it is trying to get the pact from pactflow?
john
2021-12-20 01:13
```Error reading file from https://mypactflow.pactflow.io/pacts/provider/GraphQLProvider/consumer/GraphQLConsumer/latest/
HTTP request failed: status=401 /var/www/vendor/pact-foundation/pact-php/pact/lib/vendor/ruby/2.2.0/gems/pact-support-1.15.1/lib/pact/consumer_contract/pact_file.rb:71:in `block in get_remote_with_retry'```
matt.fellows
2021-12-20 01:23
libiconv is a pretty core library for dealing with character encodings, from memory
matt.fellows
2021-12-20 01:24
It?s either going to be:
1. Missing auth token
2. Invalid auth token
3. You don?t have permissions / read-only token
matt.fellows
2021-12-20 01:24
if you?re using Docker, be sure to check that the environment variable is correctly passed into the container
john
2021-12-20 03:04
sorry Matt, i didnt see your reply. So basically I need to somehow set up the auth token in docker and pass that to the container.
so basicaly just set the bearer token in the header
agustin.gomes
2022-02-09 17:04
Hello folks :wave:
This PR hasn't gotten any reviews. Can it be given a review in the next days? the changes are quite simple, and I'd be happy to apply further feedback if required.
phongthornk
2022-02-24 17:54
I really want to implement this for PHP. However, I try to start to implement Pact-PHP with Laravel. I get these errors when I run tests
```Server error: `GET http://localhost:38189/users/1` resulted in a `500 Internal Server Error` response:
{"message":"Multiple interaction found for GET /users/1","matching_interactions":[{"description":"A get request to /user (truncated...)
at vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:113
109? if ($summary !== null) {
110? $message .= ":\n{$summary}\n";
111? }
112?
? 113? return new $className($message, $request, $response, $previous, $handlerContext);
114? }
115?
116? /**
117? * Obfuscates URI if there is a username and a password present
+10 vendor frames
11 tests/Consumer/Service/ConsumerServiceHelloTest.php:64
GuzzleHttp\Client::request()```
This is my test code
```<?php
namespace Tests\Consumer\Service;
use Exception;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\GuzzleException;
use PhpPact\Consumer\InteractionBuilder;
use PhpPact\Consumer\Matcher\Matcher;
use PhpPact\Consumer\Model\ConsumerRequest;
use PhpPact\Consumer\Model\ProviderResponse;
use PhpPact\Standalone\MockService\MockServerEnvConfig;
use PHPUnit\Framework\TestCase;
class ConsumerServiceHelloTest extends TestCase
{
/**
* Example PACT test.
*
* @throws Exception
* @throws GuzzleException
*/
public function testGetUserWithGivenId()
{
$matcher = new Matcher();
// Create your expected request from the consumer.
$request = new ConsumerRequest();
$request
->setMethod('GET')
->setPath('/users/1')
->addHeader('Content-Type', 'application/json');
// Create your expected response from the provider.
$response = new ProviderResponse();
$response
->setStatus(200)
->addHeader('Content-Type', 'application/json')
->setBody([
'id' => 1
]);
// Create a configuration that reflects the server that was started. You can create a custom MockServerConfigInterface if needed.
$config = new MockServerEnvConfig();
$builder = new InteractionBuilder($config);
$builder
->uponReceiving('A get request to /users/{id}')
->with($request)
->willRespondWith($response); // This has to be last. This is what makes an API request to the Mock Server to set the interaction.
$client = new Client([
'base_uri' => $config->getBaseUri(),
]);
$result = $client->request('GET', '/users/1', [
'headers' => [
'Content-Type' => 'application/json',
],
]);
$builder->verify(); // This will verify that the interactions took place.
$this->assertEquals('', $result); // Make your assertions.
}
}```
Debug
```[2022-02-25T00:53:14.684488 #35930] DEBUG -- : {
"description": "A get request to /users/{id}",
"request": {
"method": "GET",
"path": "/users/1",
"headers": {
"Content-Type": "application/json"
}
},
"response": {
"status": 200,
"headers": {
"Content-Type": "application/json"
},
"body": {
"id": 1
}
},
"metadata": null
}```
Please suggest to me :slightly_smiling_face:
matt.fellows
2022-02-24 22:00
That error usually comes up when there is a conflicting scenario name (`uponReceiving` ) and request details without a state to differentiate the requests. I can?t see it in your test, so this could be that there is a different test somewhere else with the same details.
Alternatively, the pact write mode could be `merge` and the pact already has that request in it. In that case, you should clear out the pact file before running your tests
phongthornk
2022-02-25 02:43
@matt.fellows With the pact-php do not require to install pact-ruby-standalone, right? It can running from phpunit.xml. Am I understand, right?
phongthornk
2022-02-25 02:49
Maybe I still don't understand about the state in pact I see this and not clear why I need to setup
matt.fellows
2022-02-25 02:52
is the above your entire setup? It seems like you might be missing something. Are there other tests?
matt.fellows
2022-02-25 02:52
Alternatively, you might not be calling the appropriate lifecycle methods to start/stop the mock server (hence why it thinks it?s seeing a duplicate)
phongthornk
2022-02-25 03:00
I am still confused about how to run a pact with PHP. I try to compare setup from go-workshop, but it differently.
phongthornk
2022-02-25 03:04
Last time, I run a pack-mock-server with a standalone outside PHP project and see the result. So I need to add this `$builder->finalize()` to clear interactions when test end
see updated code:
```$request = new ConsumerRequest();
$request->setMethod("GET")
->setPath("/users/1")
->addHeader("Accept", "application/json");
$response = new ProviderResponse();
$response->setStatus(200)
->addHeader("Content-Type", "application/json")
->setBody([
"id" => 1,
"name" => "John Doe",
"email" => ""
]);
$config = new MockServerEnvConfig();
$config->setLog(true)
->setLogLevel('debug');
$builder = new InteractionBuilder($config);
$builder->given("User with id 1 exists")
->uponReceiving("GET user for id: 1")
->with($request)
->willRespondWith($response);
$client = new Client(["base_uri" => $config->getBaseUri()]);
$userApi = new UserApi($client);
$result = $userApi->getUserById(1);
$this->assertTrue($builder->verify());
$this->assertEquals(1, $result->id);
$this->assertEquals('John Doe', $result->name);
$this->assertEquals('', $result->email);
$builder->finalize();```
Now it can generate pact file, but need to configure running pact-mock-server with phpunit.xml
phongthornk
2022-02-25 03:07
phpunit.xaml
```<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
bootstrap="vendor/autoload.php"
colors="true"
>
<listeners>
<listener class="PhpPact\Consumer\Listener\PactTestListener">
<arguments>
<array>
<element key="0">
<string>PhpPact Example Tests</string>
</element>
</array>
</arguments>
</listener>
</listeners>
<testsuites>
<testsuite name="Unit">
<directory suffix="Test.php">./tests/Unit</directory>
</testsuite>
<testsuite name="Feature">
<directory suffix="Test.php">./tests/Feature</directory>
</testsuite>
<testsuite name="PhpPact Example Tests">
<directory>./tests/Consumer</directory>
</testsuite>
</testsuites>
<coverage processUncoveredFiles="true">
<include>
<directory suffix=".php">./app</directory>
</include>
</coverage>
<php>
<env name="APP_ENV" value="testing"/>
<env name="BCRYPT_ROUNDS" value="4"/>
<env name="CACHE_DRIVER" value="array"/>
<env name="MAIL_MAILER" value="array"/>
<env name="QUEUE_CONNECTION" value="sync"/>
<env name="SESSION_DRIVER" value="array"/>
<env name="TELESCOPE_ENABLED" value="false"/>
<env name="PACT_MOCK_SERVER_HOST" value="localhost"/>
<env name="PACT_MOCK_SERVER_PORT" value="7200"/>
<env name="PACT_CONSUMER_NAME" value="Frontend"/>
<env name="PACT_CONSUMER_VERSION" value="1.0.0"/>
<env name="PACT_CONSUMER_TAG" value="master"/>
<env name="PACT_PROVIDER_NAME" value="UserApi"/>
<env name="PACT_OUTPUT_DIR" value=".\example\output"/>
<env name="PACT_MOCK_SERVER_HEALTH_CHECK_TIMEOUT" value="10"/>
<!-- <env name="PACT_BROKER_URI" value="http://localhost"/> -->
</php>
</phpunit>```
phongthornk
2022-02-25 03:09
Hmm, Look like PHPUnit can run pact-mock-server now. Not sure I missing something.
matt.fellows
2022-02-25 03:12
I read https://github.com/pact-foundation/pact-php/#start-and-stop-the-mock-server but don?t really know about PHP listeners
matt.fellows
2022-02-25 03:12
I don?t think you should be starting/stopping the Ruby standalone yourself. It looks like there are PHP methods to do it
matt.fellows
2022-02-25 03:13
you can either a) do a `$server->start();` before your tests and `$server->stop();` after them, or b) use the listeners (I think you?re using the listeners)
phongthornk
2022-02-25 03:14
Yes, you're right. Yesterday I spend more time running it along with Phpunit from the link you share with me. I try to make sure no need to install Ruby and use the standalone like go-workshop
phongthornk
2022-02-25 03:17
Yesterday, I got an error that failed to connect localhost:7200. pact-mock-server not running.
phongthornk
2022-02-25 03:21
Not sure. Maybe related to the order of phpunit.xml. Today I just change the line of it before testsuite and it works.
phongthornk
2022-02-25 03:25
@matt.fellows Could you please explain about state in pact? I see it need database or file
matt.fellows
2022-02-25 03:49
A state is a general concept. In order to test complex scenarios with pact, your provide may need to be in a particular ?state? to work.
e.g. your provider might need to have ?user A exist? in the database, for a request to `/users/A` to return a `200`
it might have a state ?user is unauthorized? to return a `403`
it might expect the state to be ?backend is unavailable? for a request to return a `500`
A state could require you to mock api calls, seed a database, stub internal components etc.
matt.fellows
2022-02-25 03:50
You can use it to test the same calls with multiple responses (e.g. for users, it could be a `200` or a `404` if it doesn?t exist)
phongthornk
2022-02-25 04:43
Ahh sorry for the unclear text. I mean state is the same with pact file, right?
phongthornk
2022-02-25 04:44
I think it just only texts to tell me what is the test case.
```Given("User sally exists").
UponReceiving("A request to login with user 'sally'").```
This is part of state, right?
matt.fellows
2022-02-25 04:45
yes. your consumer test says what state each test should be in, that?s written to the pact file.
matt.fellows
2022-02-25 04:45
The combination of `Given` and `UponReceiving` is the scenario you?re testing
matt.fellows
2022-02-25 04:45
you can have the same `UponReceiving` but with different `Given` to test different sub-scenarios
matt.fellows
2022-02-25 04:46
the state is just a string (or an object, in later versions of the spec) that the provider test can used to determine how to get into that state. How you do that, is very specific to your code
phongthornk
2022-02-25 04:47
Maybe I just need to explore and learn more. Thanks so much for your explanation. :pray:
matt.fellows
2022-02-25 04:48
Pact consumer test generate a pact file (the contract)
Contract get?s published to broker (usually, but you can use the pact file)
Provider verifies the contract
2022-02-25 04:48
Here are a number of useful hands-on labs that teach all of the key concepts: https://docs.pactflow.io/docs/workshops and https://docs.pact.io/implementation_guides/workshops
phongthornk
2022-02-25 05:20
@matt.fellows What is the exactly BrokerUri in the part of provider? I saw it try to read pact file from this endpoint
phongthornk
2022-02-27 12:59
I try to run the next step to verify the pact file from the consumer, but I got this error Not sure why?
```/home/altelma/projects/Jormungandr/pact-workshop-php/example/output/frontend-userapi.json --provider='UserApi' --provider-base-url=http://localhost:8000 --provider-states-setup-url=http://localhost:8000/setup-state [] []
[2022-02-27T12:52:48.781655+00:00] console.debug: Exit code: 2 [] []
[2022-02-27T12:52:48.783429+00:00] http://console.info: out > [] []
[2022-02-27T12:52:48.783550+00:00] console.error: err > No value provided for required options '--provider-base-url'```
tien.xuan.vo
2022-03-03 15:26
Hi @cfmack, I'm Tien, the one who created merge request to use https://github.com/pact-foundation/pact-php/pull/210. I know you are busy, and that merge request is big, so it's hard to review. That's why I think we can split that merge request into smaller merge requests. To do that, I suggest we create a https://github.com/pact-foundation/pact-php/projects?type=beta so we can work together there. You can give advice, we can discuss, create merge request, review, track progress from there.
I can think of 2 projects in mind:
? Use Rust FFI
? Support Plugins (CSV, Protobuf)
We can start the latter after we finished the former.
What do you think?
karl.wagner
2022-03-15 12:36
Hi all. I hope you can help me here. I am currently trying to write some consumer tests in pact-php (7.0.1) under phpunit (5.7.27) on php 7.4.28. I am using the listener functionality to launch the (Ruby-based?) pact-mock-service. This seemed to work reasonably, but seems to hit a limit after about half a dozen tests, at which point the mock server freezes and starts timing out. Oddly, when it does so, the underlying curl_exec call to the mock server times the request out, but never returns either. I am hitting a wall with attempts to diagnose this right now? I would appreciate any help you may be able and willing to offer.
phongthornk
2022-03-18 05:14
Is it possible to use Pact with wrapper Client class?
```use GuzzleHttp\Client;
Class InternalClient extends Client
{
// ....
}
Class UserApi
{
public function __construct(private InterClient $client)
{
}
}```
In this case, I should mock InternalClient or UserApi?
Now, I got this error
```Server error: `GET http://localhost:7200/interactions/verification` resulted in a `500 Internal Server Error` response:
Actual interactions do not match expected interactions for mock MockService.
Incorrect requests:
GET /v1/sso-user/id (truncated...) ```
matt.fellows
2022-03-18 06:05
I don?t see how a wrapper client class has anything to do with the problem
matt.fellows
2022-03-18 06:06
What your api client (wrapper or otherwise) does needs to match up with your unit test expectations
phongthornk
2022-03-18 06:14
The problem should cause by `base_uri` , I the API Client not use this to set default endpoint. The endpoint will be placed in UserAPi like this
```Class UserApi
{
public function __construct(private InterClient $client)
{
$this->client->setEndpoint('http://localhost/v1/user');
}
}```
But in the example of Pact PHP see only a way to mock with base_uri.
```$service = new HttpClientService($config->getBaseUri()); // Pass in the URL to the Mock Server.
$result = $service->getHelloString('Bob'); // Make the real API request against the Mock Server.```
Because our API Client does not use base_uri. It makes a request by itself like this
```public function request($method, $uri = '', array $options = []) : ResponseInterface
{
$uri = $this->baseUrl . $uri;
try {
$response = $this->makeRequest($method, $uri, $options);
....
}```
This is an override Client method. Now I try to create a new Class using the default Client class (GuzzleHttp) instead of the custom Client API class. See it work properly. Need to try more . . .
matt.fellows
2022-03-18 06:21
You need to be able to dynamically configure your API client to send requests to the mock server, and not the real one. How you do that Pact doesn?t really care
phongthornk
2022-03-18 06:25
OK, Thank you so much. Really need to take more time on this. :slightly_smiling_face:
phongthornk
2022-03-18 08:03
Hello, I had a question about Pact (Contract Testing), Can I use or run it together with unit testing in case of any Class have a method or function to make an API to providers. Or it should create a test separately with consumer test only?
Example code to write unit test
``` /**
* @throws GuzzleException
*/
public function register(array $params): string
{
$request = [
'email' => '',
'password' => 'password',
];
// This line below try to call API to another service
$response = $this->registrationApi->registerUser($request);
return $response['data']['request_id'];
}```
In the example above, Can I do like mention before? to combine between unit testing and Pact?
Normally, I will use mock API to serve responses as expected such as mountebank, wiremock, etc.
phongthornk
2022-03-21 03:32
Does anyone have an example to use `setRequestFilter()` I was trying but not working.
matt.fellows
2022-04-28 08:07
@tien.xuan.vo @cfmack we?re looking to drop a Pactflow POST to our ~8k user database in the next few days. I?d like to provide an update on all of the great work going on with rust integration and celebrate the good work - what?s the current status? Is it in a state where you would want any beta users or contributors to get involved?
matt.fellows
2022-04-28 08:13
is it in a beta release or something people can muck about with or is that still a bit away?
matt.fellows
2022-04-28 08:18
don?t be sorry - very appreciative of your work! I think we need to find a way to get your more help and/or support. It?s hard to review such a drastic change, so I can understand any sluggishness there
sagupta
2022-05-17 15:40
Hello team,
I have just started implementing a test case using pact-php and i am facing an issue where the consumer repo is a consumer to 3 API . So i plan on creating 3 test case files (one for each provider) and i want to set the provider name for each api . So far i dont see how can i do that . I am setting `PACT_PROVIDER_NAME` from the environment file (in my case i am running the consumer inside a docker container so a .env file) .
I tried using below code in the test itself but its not overwriting the environment variable.
```putenv("PACT_PROVIDER_NAME=some-api");```
I am using `MockServerEnvConfig()` to get the configurations.
Can someone explain how can we do it ?
matt.fellows
2022-05-18 00:49
in that case, don?t use the `EnvConfig` version, and then you can use `$config->setProvider('someProvider');`
matt.fellows
2022-05-18 00:49
(I haven?t tried this, but the https://github.com/pact-foundation/pact-php#start-and-stop-the-mock-server suggest it)
sagupta
2022-05-18 12:56
alright yea that works for me . So in this case i have to start the server manually which is not a problem. I can extract out this config in a function which i will need to call in every test as a `before` condition.
I am thinking about stopping the server when a exception is thrown from test
lewiscowles
2022-05-24 09:48
I Sometimes wonder if the errors are deliberately obtuse... https://github.com/pact-foundation/pact-php/runs/6570723077?check_suite_focus=true
lewiscowles
2022-05-24 16:47
Added the new http://test.pactflow.io url to this now instead of http://test.pact.dius.com.au
Makes me think this is not run often enough.
yousafn
2022-05-24 21:30
Ahh yes, the url was decommissioned on the 2nd May
https://docs.pactflow.io/notices/2022-03-28-pact-dius-com-au-decommission
and the last changes were 29 days ago to master, so that slipped the net.
Comms and co-ordination across the repos for maintainers is high on my list at the moment, as well of ideas to build robust and similar workflows across the libraries to ensure that when changes are made, they are appropriately tested and filtered through.
The process is quite slick on some repos which are heavily used, but others are maintained often by single maintainers, so the extra eyes and feedback of new contributors and maintainers alike is really valuable.
Appreciate the extra effort going in to make debugging easier to distinguish in future.
Will co-ordinate with the maintainers and key contributors and see what we can rustle up, ensuring that we do it in the open so others can get involved
yousafn
2022-05-24 21:32
Obtuse errors frustrate me, I watched a video where someone mentioned one of the best things they did was every time they got an error and it was just garbage on their screen, they would clean up the logging to make it easier to grok for others. Might have been a podcast
matt.fellows
2022-05-24 22:19
Yes, that is strange. It?s hard to know where/why that error is occurring.
tien.xuan.vo
2022-05-25 02:10
That's because there are https://github.com/pact-foundation/pact-php/blob/master/src/PhpPact/Standalone/Broker/Broker.php#L24 that need `pact-broker` binary from ruby-standalone, but I can't find any alternate version written in Rust yet.
lewiscowles
2022-05-25 02:23
I'm just seeing if I can get your code running faster than a patch for what is. But that is the very part I'd like to get rid of (well any sub-process calls really)
lewiscowles
2022-05-25 02:25
One potential part that can be pulled out that at least we agree on seems to be the updating of the API url to the new http://test.pactflow.io btw
lewiscowles
2022-05-25 02:42
well fixing url is basically https://pact-foundation.slack.com/archives/C9W94PXPY/p1653422150465959
lewiscowles
2022-05-25 02:46
Your code has this. The point is that it can be a separate PR. Maybe all the choices could be.
lewiscowles
2022-05-25 02:47
in any case it's working for my local but failing in GitHub. Something else I know you'd mentioned to the pactflow team
lewiscowles
2022-05-25 02:54
Ah, now I'm running it in my GitHub actions it sometimes fails, but other times not... https://github.com/Lewiscowles1986/pact-php/actions/runs/2380311568 I think there are race conditions in the code.
lewiscowles
2022-05-25 02:59
http://test.pact.dius.com.au won't work while decommissioned
Although it is failed in pactflow branch, https://github.com/Lewiscowles1986/pact-php/actions/runs/2380311568 shows this same code passing. This seems to be due to race conditions.
lewiscowles
2022-05-25 03:03
Also while I might abstractly agree on improving logging, if you know where the logs are coming from. a large part of the suggested approach creates extra line-count in PR's and patches, which are then harder to read, review, and inevitably take more time to author, test; and with a sample size of 1 (me) might just be opinion pieces.
lewiscowles
2022-05-25 03:23
large issue capturing. It can be closed if it is an opinion piece https://github.com/pact-foundation/pact-php/issues/250
lewiscowles
2022-05-25 04:22
https://github.com/Lewiscowles1986/pact-php/pull/3 is building now. Works on my local
? removes additional `pact` folder for less changes than `master`
? switches from `pact-stub-server.exe` to `pact-stub-service.bat`
? uses updated http://pactflow.io url
Less opinionated take is https://github.com/Lewiscowles1986/pact-php/pull/4 which avoids reverting changes to directory structure.
lewiscowles
2022-05-25 06:01
on ubuntu I just checked this is the same. So I've checked on Windows and Ubuntu
lewiscowles
2022-05-25 06:03
are you by-chance ensuring when you run locally you `rm -rf pact` between runs? I have been since I found that the nested `pact/pact` was a deeper issue. Originally I'd been running `master` then switched to your branch. Which mildly concerns me if people run an upgrade and was why I doubled-down on removing and just having one `pact` directory
lewiscowles
2022-05-25 10:56
If anyone has any bandwidth to get any of the pact-php branches over the line, I don't know what is the issue with pact-foundation pact-php CI, but the same github yaml works https://github.com/Lewiscowles1986/pact-php/pulls there is a PR to fix a URL, and a separate one to help get an FFI patch through.
matt.fellows
2022-05-25 11:40
The URL one looks so basic I just want to merge it, but I think it best the maintainer does that as they own the consequences. It?s possible there is some quantum state causing unreliability, and it just happens to reliably fail on our GH (seems strange, we don?t run custom runners or anything)
lewiscowles
2022-05-25 11:41
It seems to be flaky even on my runners, but it works. I think it must have always been flaky or people get lucky
lewiscowles
2022-05-25 11:42
Note: this FFI does less than the original. Mostly because I found some issues with shared objects I thought it cruel to pass on, which were leading to some pipeline failures, which did not mention the missing .so files (running the commands directly did though).
matt.fellows
2022-05-25 11:52
Did you re-write it or just tweak what Tien had done? (I?m watching from a far, so am not across the detail).
Is it functional? that is, can you use it in your pipelines reliably?
lewiscowles
2022-05-25 11:53
Passes all tests is as far as I've got with it, but timing those it saves > 1 minute
lewiscowles
2022-05-25 11:54
I've also tested on osx, linux and windows now (pet machines local + github)
lewiscowles
2022-05-25 11:54
It should have less failure points. Once FFI handles everything the ruby does it'll be mint (very good)
lewiscowles
2022-05-25 11:55
(apologies for colloquialisms, multiple conversations, one with someone from north of england)
matt.fellows
2022-05-25 11:55
all good. Australian here, mint is a thing (or, at least at some point in my life it was a thing)
matt.fellows
2022-05-25 11:57
On the Rust integration to PHP, once concern I have is that it?s such a big PR for a maintainer to get and then do anything practically with. It?s an obviously good thing (we want everyone on the FFI) but also, once the code is merged in it?s the maintainer?s job to keep it alive.
matt.fellows
2022-05-25 11:57
@cfmack how do you think we should approach :point_up: ?
cc: @yousafn (something for consideration as we scale)
lewiscowles
2022-05-25 11:58
Once the url fix lands, I want to make one more tiny PR to run scheduled weekly builds in PHP pact, but I'm leaving my job soon so will likely leave PHP to rot afterwards.
lewiscowles
2022-05-25 16:39
but it will fix the test suites and give future visibility into breakages...
lewiscowles
2022-05-25 17:19
Afraid I'm an Essex man, but I've been to Manchester and most places :wink:
lewiscowles
2022-05-27 12:36
Once PHP `Lewiscowles1986:bugfix/update-pact-url` can be merged, we can also work with new `pact-standalone` `1.88.90` in pact-php
yousafn
2022-05-27 13:01
5 minutes into looking at that, and already down a rabbit hole
https://github.com/pact-foundation/pact-php/pull/249#issuecomment-1139595563
:joy: Have merged, the main maintainer is asleep and the rest of the team are on Aus time so Friday eve, so probably just you and me on this train.
I'm doing some GH stuff for a couple of hours so you can nudge me
lewiscowles
2022-05-27 13:16
https://github.com/pact-foundation/pact-php/pull/253 This one introduces scheduled builds so that if a maintainer gets "life happen" :tm: then you can still as an org know if that package is failing, and get visibility before a customer comes to you. It's a thing I use if i want to show something so that I know it should always be build-able.
yousafn
2022-05-27 13:17
Nice one, just raised a snagging list/maintenance checklist for repos, so this and any other ideas you have are good to add to that list.
I'll refine it and move it to a central location at some point to track and monitor across the repos.
https://github.com/pact-foundation/pact-php/issues/254
yousafn
2022-05-27 13:26
bit of that engineering special sauce, makes a good thing better :chefkiss: I like to try to avoid a broken:window: culture, but it is difficult when the estate is so vast
Love this :ok_hand:
> l if a maintainer gets "life happen" :tm:
Really appreciate your effort's, this is what OSS is all about :clap:
lewiscowles
2022-05-27 13:26
Well I appreciate it's a very small part of the overall PACT space. In my new upcoming role, I am likely to work with PACT again via NodeJS
lewiscowles
2022-05-27 13:38
https://github.com/pact-foundation/pact-php/pull/252 is just flaky tests. I Believe I made a large issue about this https://github.com/pact-foundation/pact-php/issues/250
yousafn
2022-05-27 13:46
If you set `fail-fast: false` it won't fail all the matrix jobs and might let us see if its failing on all those jobs or one consistently
I think it is only failing one of the triggered workflows consistently, one that is triggerd by `PULL_REQUEST_TARGET`
lewiscowles
2022-05-27 13:48
believe it or not. It seems to check the `master` branch, so I can't just update my PR to fix that.
yousafn
2022-05-27 13:49
:slightly_smiling_face: I'll do it otherwise at some point today if not, I think that is correct that it checks master based on what I skimmed in the docs. One more failing build can't hurt, if we get one every PR anyway :joy:
lewiscowles
2022-05-27 14:13
See flaky pipeline. I think this is races due to async. Once FFI is in this will calm down as it won't be using AmPHP Process (likely how that is used, not the package that is the issue)
yousafn
2022-05-27 14:34
aye man, flakey pipelines be no fun for anyone. have dropped the `pull_request_target` now and set `fail_fast: false` so that along with your improvements and we should be onto a winner, and Mack can live a happy life.
yousafn
2022-05-27 19:21
@tien.xuan.vo thanks for all your incredible work on this so far. I will do everything I can you help you all get this over the line.
Looks like my good friend Lewis who has recently had eyes on the builds is here too so we are in the right place
lewiscowles
2022-05-28 02:48
@tien.xuan.vo I mostly made similar changes (updated URL), but with the difference being that my fork of your branch does not change to the older seemingly un[der]maintained https://github.com/pact-foundation/pact-stub-server. I created https://github.com/pact-foundation/pact-stub-server/issues/47 to track one issue of getting rid of that.
lewiscowles
2022-05-28 02:51
It is still quite a large PR. I wonder if there is a way to make a list of things we want it to do, and then a list of the changes required, so that it might be easier to collaborate on smaller deliverables towards to goal.
lewiscowles
2022-05-28 03:11
1.88.90 for pact-php passing now https://github.com/pact-foundation/pact-php/pull/252
tien.xuan.vo
2022-05-30 02:01
> It is still quite a large PR. I wonder if there is a way to make a list of things we want it to do, and then a list of the changes required
I didn't prepare that list yet. But I did suggest we can create that list in https://github.com/pact-foundation/pact-php/projects?type=beta so we can collaborate there (see my original message of this thread).
tien.xuan.vo
2022-05-30 02:02
I think https://github.com/tienvx/pact-php/blob/rust-ffi/UPGRADE-8.0.md is a good starting point, we can break down items based on that list
lewiscowles
2022-06-03 07:14
Hey, Sorry I missed this. UPGRADE looks a great place to break things out. To be honest several of them look like standalone PR's
As I can't create a project from the first link, do you think an issue might be a better starting point? GitHub supports `* [ ] sub-task` lists which can be used to tick off each item.
tien.xuan.vo
2022-06-03 07:28
I think the very first sub-task should be:
`[ ] Discuss about a separate branch for 8.x code. Create new branch 8.x, or 7.x and work on master`
lewiscowles
2022-06-03 07:38
rene.klatt
2022-08-03 10:35
Hello,
I have an issue with my first setup and need your help, please.
`Failed to make connection to Mock Server in 10 attempts.`
See details in the thread.
rene.klatt
2022-08-03 10:35
When I run my tests I get the following output:
```server.debug: start background command: .../vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/../../../../pact/bin/pact-mock-service service --consumer='myConsumer' --provider='myProvider' --pact-dir='.../tests/_data/pact' --pact-file-write-mode=overwrite --host=localhost --port=7201 --cors=true [] []
[2022-08-03T08:50:26.030467+00:00] server.debug: started process pid=48193
There was 1 error:
---------
1) ContractTest: Connect an app
Test Contract/ContractTest.php:testConnectAnApp
[PhpPact\Standalone\Exception\HealthCheckFailedException] Failed to make connection to Mock Server in 10 attempts.
#1 .../vendor/pact-foundation/pact-php/src/PhpPact/Standalone/MockService/MockServer.php:168
#2 .../vendor/pact-foundation/pact-php/src/PhpPact/Standalone/MockService/MockServer.php:65
#3 .../tests/Contract/ContractTest.php:74
#4 .../vendor/bin/codecept:117```
I?m also unable to start the `pact-mock-service` with `vendor/pact-foundation/pact-php/pact/bin/pact-mock-service service --consumer='myConsumer' --provider='myProvider' --pact-dir='.../tests/_data/pact' --pact-file-write-mode=overwrite --host=localhost --port=7201 --cors=true`
there I get
```.../vendor/pact-foundation/pact-php/pact/lib/ruby/bin/ruby: line 6: .../vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby: cannot execute binary file
.../vendor/pact-foundation/pact-php/pact/lib/ruby/bin/ruby: line 6: .../vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby: Undefined error: 0```
What do I miss here? Do you need any other information?
matt.fellows
2022-08-03 11:20
Can you please run the following commands (please replace the ? with the correct prefix):
```file .../vendor/pact-foundation/pact-php/pact/lib/ruby/bin/ruby
file .../vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby:```
rene.klatt
2022-08-03 11:23
The first one gives me
```vendor/pact-foundation/pact-php/pact/lib/ruby/bin/ruby: line 6: .../vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby: cannot execute binary file
vendor/pact-foundation/pact-php/pact/lib/ruby/bin/ruby: line 6: .../vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby: Undefined error: 0```
The second one
`zsh: exec format error: vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby`
matt.fellows
2022-08-03 11:27
Also, once that has completed, could you please try installing that package manually (see https://github.com/pact-foundation/pact-ruby-standalone/releases/tag/v1.89.02-rc1, which is what Pact PHP should bootstrap under the hood)
rene.klatt
2022-08-03 11:27
1. `vendor/pact-foundation/pact-php/pact/lib/ruby/bin/ruby: Bourne-Again shell script text executable, ASCII text`
2. `vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.9, stripped`
matt.fellows
2022-08-03 11:30
ok that looks to be the issue. For some reason, it?s downloaded a linux 64 bit binary
matt.fellows
2022-08-03 11:31
I don?t know PHP, but presumably when you install packages there is some log out
rene.klatt
2022-08-03 11:31
But that might already help me debug the whole thing. Maybe I can see where the installation happens.
rene.klatt
2022-08-03 11:32
I installed via composer and run the tests, AFAIK the download will happen the first time when you run the tests. I?ll check.
Thank you for your support. If I?m stuck again I?ll drop a message here.
alex.makdessi
2022-08-04 13:08
Hello :wave:
I'm trying to setup provider states using the `--provider-states-setup-url` option. However, on the endpoint I configured, I'm receiving a `null` state
This is what my endpoint is receiving:
```{"body":{"consumer":"ms.pact-consumer-example-for-php","state":null,"states":[null],"params":[]}}```
alex.makdessi
2022-08-04 13:12
heres the pact file i'm fetching from the broker:
```{
"consumer": {
"name": "ms.pact-consumer-example-for-php"
},
"provider": {
"name": "ms.pact-provider-example-for-php"
},
"interactions": [
{
"description": "A request for a product",
"providerState": "A produ?ct with id c931b702-f48a-447c-8619-80556f40e82b exists",
"request": {
"method": "GET",
"path": "/api/v1/products/c931b702-f48a-447c-8619-80556f40e82b",
"headers": {
"Content-Type": "application/json"
}
},
"response": {
"status": 200,
"headers": {
"Content-Type": "application/json"
},
"body": {
"id": "c931b702-f48a-447c-8619-80556f40e82b",
"name": "Drill",
"brand": "Makita"
},
"matchingRules": {
"$.body.id": {
"match": "regex",
"regex": "^[0-9a-f]{8}(-[0-9a-f]{4}){3}-[0-9a-f]{12}$"
},
"$.body.name": {
"match": "type"
},
"$.body.brand": {
"match": "type"
}
}
}
},
{
"description": "A request for a product",
"providerState": "There is no product with id 9b40cb15-dfcf-496f-9ba2-208312a25527",
"request": {
"method": "GET",
"path": "/api/v1/products/9b40cb15-dfcf-496f-9ba2-208312a25527",
"headers": {
"Content-Type": "application/json"
}
},
"response": {
"status": 404,
"headers": {
"Content-Type": "application/json"
},
"body": {
"error": {
"message": "The product with id \"9b40cb15-dfcf-496f-9ba2-208312a25527\" does not exists",
"app_code": "PRODUCT_NOT_FOUND"
}
},
"matchingRules": {
"$.body.error.message": {
"match": "type"
},
"$.body.error.app_code": {
"match": "type"
}
}
}
}
],
"metadata": {
"pactSpecification": {
"version": "3.0.0"
}
}
}```
yousafn
2022-08-04 13:18
Hey buddy,
I don't believe pact-php supports v3.0.0 spec of the pact-specification
https://github.com/pact-foundation/pact-php#specifications
it may be a red herring, but food for thought
yousafn
2022-08-04 13:22
:thinking_face: Hmm so the pact-verifier functionality in pact-php
https://github.com/pact-foundation/pact-php#provider-verification
uses the ruby standalone verifier https://github.com/pact-foundation/pact-provider-verifier
Looking at that readme, that should support v3
https://github.com/pact-foundation/pact-provider-verifier#pact-specification-v3-provider-state-support
That is part of a larger section of verification of provider states in the readme
https://github.com/pact-foundation/pact-provider-verifier#api-with-provider-states
You could try `providerStates` with a v2 pact spec and see if that resolves it, and if so I would assume there is some work in PHP, if not it will be something else :thumbsup:
alex.makdessi
2022-08-04 13:39
Thanks for your help @yousafn,it was a spec version issue :clap:
I regenerated the pact file using `2.0.0` on the consumer side, and now i'm receiving this body in my setup endpoint
```{"body":{"consumer":"ms.pact-consumer-example-for-php","state":"A product with id c931b702-f48a-447c-8619-80556f40e82b exists","states":["A product with id c931b702-f48a-447c-8619-80556f40e82b exists"],"params":[]}}```
I assume that I should use the `state` key instead of the `states` one ?
yousafn
2022-08-04 13:40
awesome!
Aye I think based on the comment below, that states should be ignored, inferring use `state` :thumbsup:
> Ignore the `states` array that you will see if you happen to print out the live provider state set up request body
Good luck in your pact Journey buddy!
rene.klatt
2022-08-04 14:39
@matt.fellows I had to switch to docker now and I?m facing a new issue. We are running on alpine and I get issues like `Error relocating /data/vendor/pact-foundation/pact-php/pact/lib/ruby/bin.real/ruby: backtrace: symbol not found`
A colleague said that the standalone executables are built for x86_64 with glibc and not with musl.
Can you point me to something that helps me get it run in docker alpine?
How will the PHP package then know which executables to use when the ones downloaded do not work?
matt.fellows
2022-08-05 04:00
The version you have should be able to work on Alpine docker. But that error doesn?t look familiar
rene.klatt
2022-08-05 07:53
I run tests on the provider side and there are two runs of the interaction. The first one runs fine `1 interaction, 0 failures` but the second one fails because the entity I create already exists in the second run.
Is that something I can somehow configure? What is the second run of the same interaction for?
lewiscowles
2022-09-04 17:59
:face_with_symbols_on_mouth:
> Animal Profile Service
was renamed to
> Animal Profile Service V3
Surely a V3 could just be a new one, leaving the other one (and downstream repos) working. Stable URL's isn't even new, it's been a principal for decades.
alex.makdessi
2022-09-13 20:29
Hello, I think there's a mistake on the pact-php `VerifierConfig` option to set the `pact-provider-verifier` log directory:
? https://github.com/pact-foundation/pact-provider-verifier#usage use a `--log-dir` option name to define the log director
? the https://github.com/pact-foundation/pact-php/blob/8.0.0/src/PhpPact/Standalone/ProviderVerifier/Verifier.php#L131 is setting a `--log` option
matt.fellows
2022-09-13 22:38
Thanks, if that?s the case could you please raise an issue on the GH repo?
alex.makdessi
2022-09-19 12:51
Hello @matt.fellows, do you know if there is a release scheduled to tag a new minor version on pact-php ?
matt.fellows
2022-09-19 14:39
Hi Alex, sorry I don't. I can follow up later this week when back from the conference
matt.fellows
2022-09-21 13:23
Could you please share the output Rene? One guess is that it?s verifying two different pacts from the broker. We?d need to see the selectors used as well
rene.klatt
2022-09-22 11:59
Hello, @matt.fellows this issue hasn?t appeared anymore and I can?t reproduce it now. If it pops up again I will drop a message.
edouard.lopez
2022-09-22 14:23
Working on PHP implementation with colleague, we are wondering is pact-php support branch? The https://pact-foundation.slack.com/archives/C9VPNUJR2/p1661351565613229 and the README in `pact-php` only mention `setProviderBranch()` for the provider.
1. Is it the same thing?
2. How do I set the consumer's branch?
matt.fellows
2022-09-23 22:37
You set the consumer's branch when you publish the contract, which you should do with the CLI tools
cfmack
2022-10-06 03:44
Published 8.1.0. FYI, any time you have an issue, Github is the one I mostly likely follow up on
cfmack
2022-10-06 04:01
Tein Vo & Lewis, as you probably noticed, I am hardly on Slack and mostly follow up on Github as I have the time. Thank you both for all those contributions! I recently posted something on where I have bandwidth: https://github.com/pact-foundation/pact-php/pull/270#issuecomment-1243043217. Not really sure how to best proceed.
tien.xuan.vo
2022-10-06 04:14
Hi. Nice to hear that you have time to take a look at it again. My goal is to make the merge request about FFI smaller so it's easier to be reviewed. To do that, I have some idea (will be discussed in https://github.com/pact-foundation/pact-php/issues/262)
? Decide the target branch for all the merge requests. Can you decide it first? `master` , `8.x` , `9.x` ...
? Offload installers (can you edit the ticket add this item?)
? Offload console (can you edit the ticket add this item?)
? Support FFI (can you edit the ticket add this item?)
? Support Plugins (can you edit the ticket add this item?)
yousafn
2022-10-06 09:30
@cfmack :raised_hands: @tien.xuan.vo thanks for still being motivated :muscle:
I have updated the ticket to reference your pointers above.
I am really happy to help support this, my PHP knowledge isn't great, but I can muddle through, even to provide you all support in getting this out in beta for testing
tien.xuan.vo
2022-10-06 09:35
Thanks :pray: . I will wait for decision on the first point, then start a new thread to discuss about the second point after that.
yousafn
2022-10-06 09:36
Calling all PHP Pact users. Would you like to get help support the migration of Pact-PHP to the Rust core, so you can gain all the v3/v4 spec goodness?
If you can help provide support in any way, be it helping steer technical discussions, coding, alpha/beta testing or even calling on others in the PHP community to help out, it would be HUGELY appreciated by our Pact-PHP maintainer @cfmack, the Pact team, and the Pact userbase.
I am sure I can raid a swag cupboard or two to help make it more appealing. Thanks for the huge contributions so far from @tien.xuan.vo and @lewiscowles
If so, drop us a reaction, or a comment in a :thread:
:cookie: trail if anyone fancies some light reading - https://pact-foundation.slack.com/archives/C9W94PXPY/p1646321219144749
yousafn
2022-10-06 09:56
No problem dude, thanks. Following on from Lewis's comments before, I've created an org wide project called https://github.com/orgs/pact-foundation/projects/7/views/1 and assigned it to the https://github.com/pact-foundation/pact-php/projects?query=is%3Aopen project, to see if that will help us provide better tracking/visibility. Open to feedback, added this comment in the description
> This is currently a beta - Trying to provide org wide tracking of projects in GitHub, by creating them against the pact-foundation organisation and assigning to individual repos
> Unsure if that is the best approach, or if we should have a project around a theme
ad
2022-11-25 13:25
Hello, I've created this issue long time ago, but the issue is back now and blocking: https://github.com/pact-foundation/pact-php/issues/234 has anyone a idea what's going wrong there?
github2
2022-12-07 20:21
The GitHub user https://github.com/bethesque has signed out.
Use the following command/s to recreate subscriptions
/github subscribe pact-foundation/pact-php
2022-12-08 00:34
:white_check_mark: Subscribed to https://github.com/pact-foundation/pact-php. This channel will receive notifications for `issues`, `pulls`, `commits`, `releases`, `deployments`
yousafn
2022-12-14 15:07
Nice @tien.xuan.vo - honestly thank you for much for your work. It is appreciated and isn't going unnoticed, we just don't have PHP people inside the core team, I can help test it from an outside in perspective functionality wise, but in terms of best PHP practise, not so sure. Have been playing around with the FFI based on your examples in the pact-reference repo.
Good idea to help break it up, the PR's
@cfmack / @lewiscowles would you be happy help review?
Would it be an idea to create a next track so we can start rolling out these changes in a beta fashion to allow people to use/test and provide real world feedback?
Just thinking our review process is super slow as we don't have allocated people to assist with the work.
If there is anyone else you can help bring on board, and if there is any enticement I can help provide, I can work with the team, we do have an open collective budget and I am sure they may be appetite to use some of it to help get this across the line. After all it was born from donations from users of Pact
tien.xuan.vo
2022-12-14 16:35
The 3th pull request will be about `using Rust FFI` itself, but will not be available soon as I think I need to rewrite from scratch based on my big pull request to prevent as much breaking changes as possible.
lewiscowles
2022-12-21 15:38
I Approved the PR; it looks good and is mostly removing things, it should pass pipeline, but keep in mind whoever has permissions to approve the run, may need to retry (php lib flakiness). I Wrote a detailed reply to an ask for improvements. I'll be happy to test, but it might take a while, so I don't get stressed and poorly tempered :blush: . Apologies for when I've done that in the past btw; I think I was generally exhausted, but there is no good excuse for being a brat.
tien.xuan.vo
2023-01-16 03:00
Hi @lewiscowles
I think we don't have a place to note down errors we got when pipeline failed. I'm not sure comment on your ticket is a good idea, so for now I think we can note them in this thread. I hope it is okay for you.
tien.xuan.vo
2023-01-16 03:01
Let me start first:
```1) PhpPact\Standalone\Runner\ProcessRunnerTest::testBlockingProcess
Expect 'myError' to be in the stderr
Failed asserting that '' contains "myError".
D:\a\pact-php\pact-php\tests\PhpPact\Standalone\Runner\ProcessRunnerTest.php:46```
https://github.com/pact-foundation/pact-php/actions/runs/3926640569/jobs/6712552709
tien.xuan.vo
2023-03-02 10:40
``` 1) PhpPactTest\Standalone\ProviderVerifier\VerifierTest::testRunShouldLogOutputIfCmdFails
Failed asserting that 'out > ' contains "first line".
D:\a\pact-php\pact-php\tests\PhpPact\Standalone\ProviderVerifier\VerifierTest.php:231
2) PhpPactTest\Standalone\Runner\ProcessRunnerTest::testBlockingProcess
Expect 'pact' to be in the output
Failed asserting that '' contains "pact".
D:\a\pact-php\pact-php\tests\PhpPact\Standalone\Runner\ProcessRunnerTest.php:27```
https://github.com/pact-foundation/pact-php/actions/runs/4310538726/jobs/7519118927
tien.xuan.vo
2023-03-06 07:54
```1) PhpPactTest\Standalone\ProviderVerifier\VerifierTest::testVerify
Failed asserting that false is true.
D:\a\pact-php\pact-php\tests\PhpPact\Standalone\ProviderVerifier\VerifierTest.php:48```
https://github.com/pact-foundation/pact-php/actions/runs/4341095386/jobs/7580293186
tien.xuan.vo
2023-03-12 09:46
```Script phpunit --debug -c example/phpunit.all.xml handling the test event returned with error code -1073741819```
https://github.com/pact-foundation/pact-php/actions/runs/4396817297/jobs/7699527082
proy
2023-04-05 15:52
Greetings.
I came across a weird bug using the pact php package to verify the interactions with another service that acts as a consumer. Oddly, when I call "verify('devices-gateway')" on the Verifier, it's verifying another interaction with another consumer service, which is verified with a MessageVerifier in another unit test of the same provider.
It seems to be verifying the accurate consumer right at the start of my unit test, but it's abruptly ending, as these two lines of log show;
```[2023-04-05T11:57:37.873381-04:00] console.debug: Process command: /app/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/../../../../pact/bin/pact-provider-verifier https://[PACTBROKER_URL]/pacts/provider/oauth-service/consumer/devices-gateway/latest/ --provider='oauth-service' --provider-base-url=http://0.0.0.0:7202 --provider-app-version=1.0 --broker-username=[USERNAME] --broker-password=[PASSWORD] --enable-pending --include-wip-pacts-since=2020-01-30 --pact-broker-base-url=[PACTBROKER_URL]
[] []
[2023-04-05T11:57:39.443766-04:00] console.debug: Exit code: 1 [] []```
It then moves on to the other verification, even though I really mentionned "->verify('devices-gateway')" in my unit test, right before my final assertion.
I was wondering if there's anything being cached or something. When I first developed this verification unit test, I wrongly used the "verifyAll" function on the verify all, so I wonder if there's some kind of black magic going that's I'm not aware of.
Thanks for helping.
matt.fellows
2023-04-06 00:33
Ah, you might be running into an issue with the V2 spec, where you can?t verify both HTTP and non-HTTP (aka messages) in the same verification process. The verifier will fetch all pacts/consumers and verify them, and this is not supported in V2.
In V4 this is fixed, but Pact PHP does not yet support that
matt.fellows
2023-04-06 00:33
the fix is to name the provider differently for HTTP and Message verifications
proy
2023-04-06 12:53
This is exactly what was going on. And this is what we ended up going for; naming the provider differently.
We're still happy to know the problem wasn't in our implementation. Thanks for the quick answer.
nikita.gupta
2023-04-18 03:06
Hello Guys,I am verifying a request between a Kotlin based consumer and PHP based Provider service that requires authorization token send in request header (that does not change very frequently) so i added token in pact and consumer test which works fine but verifying the pact against provider respond with 401 error code.whats the best way to handle this? Should i add token on provider side(which i could not find way to add in pact-php) or i there a possibility to totally ignore token since we are using mock client to interact with provider and i don?t need to verify token.Please suggest.Thanks!
vaidas.sieber
2023-04-20 14:10
Can a bearer token be added to the provider verifier config like so:
```$config = new VerifierConfig();
$config
->header('headers' => ['Authorization' => 'Bearer <value>'])
->setRequestFilter(
function (RequestInterface $r) {
return $r->withHeader('Authorization', 'Bearer <value>');
}
);```
vaidas.sieber
2023-04-21 05:36
Response said: "401 Token not found" using setRequestFilter or no header at all. The other 2 tryouts (headers, setAdditionalRequestHeaders) return php call errors.
Following this repo guide: https://github.com/pact-foundation/pact-php#provider-verification.
```public function testPactVerifyConsumer() {
$config = new VerifierConfig();
$config
->setProviderName('Provider')
->setProviderVersion('1.0.0')
->setProviderBaseUrl(new Uri('http://localhost:8081'))
->setBrokerUri(new Uri('http://localhost:9292'))
// not working ->header('headers' => ['Authorization' => 'Bearer <value>'])
/* not working ->setRequestFilter(
function (RequestInterface $r) {
return $r->withHeader('Authorization', 'Bearer <value>');
}
);*/
;
$verifier = new Verifier($config);
// not working $verifier->setAdditionalRequestHeaders(['Authorization' => 'Bearer <value>'])
$verifier->verifyFiles([__DIR__ . '/../../../pacts/*.json']);
$this->assertTrue(true, 'Pact Verification has failed.');
}```
vaidas.sieber
2023-04-21 06:01
ChatGPT recommended, but same response "401 Token not found":
```use GuzzleHttp\Psr7\Uri;
use PhpPact\Standalone\ProviderVerifier\Model\VerifierConfig;
use PhpPact\Standalone\ProviderVerifier\Verifier;
use PhpPact\Standalone\Runner\ProcessRunner;
use PHPUnit\Framework\TestCase;
use Psr\Http\Message\RequestInterface;
public function testPactVerifyConsumer() {
$config = new VerifierConfig();
$config
->setProviderName('Provider')
->setProviderVersion('1.0.0')
->setProviderBaseUrl(new Uri('http://localhost:8081'))
->setBrokerUri(new Uri('http://localhost:9292'))
->setRequestFilter(
function (RequestInterface $r) {
$authHeader = ['Authorization' => 'Bearer <value>'];
return $r->withHeader($authHeader);
}
);
;
$verifier = new Verifier($config);
$verifier->verifyFiles([__DIR__ . '/../../../pacts/*.json']);
$this->assertTrue(true, 'Pact Verification has failed.');
}```
vaidas.sieber
2023-04-21 06:57
Just for info: I would need the token for every API call to verify the consumer, not to auth to the broker.
matt.fellows
2023-04-21 07:57
What does the output of the log file say when set to DEBUG/verbose - it should show the fully request/response
vaidas.sieber
2023-04-21 09:17
```I, [2023-04-21T09:14:13.465219 #48] INFO -- : Running example 'Verifying a pact between Consumer and Provider A request for a clients list with GET /api/clients returns a response which has status code 200'
I, [2023-04-21T09:14:13.468601 #48] INFO -- : Sending GET request to path: "/api/clients" with headers: {}, see debug logs for body
D, [2023-04-21T09:14:13.469643 #48] DEBUG -- : body :
I, [2023-04-21T09:14:15.490512 #48] INFO -- : Received response with status: 401, headers: {"Content-Type"=>"application/json", "Connection"=>"keep-alive", "Www-Authenticate"=>"Bearer", "Cache-Control"=>"no-cache, private", "Date"=>"Fri, 21 Apr 2023 09:14:14 GMT", "Link"=>"<http://localhost:8081/api/docs.jsonld>; rel=\"http://www.w3.org/ns/hydra/core#apiDocumentation\"", "X-Debug-Token"=>"3afd26", "X-Debug-Token-Link"=>"http://localhost:8081/api/_profiler/3afd26", "X-Robots-Tag"=>"noindex", "Content-Length"=>"44"}, see debug logs for body
D, [2023-04-21T09:14:15.491504 #48] DEBUG -- : body: {"code":401,"message":"JWT Token not found"}```
->setVerbose(true)
```same output```
vaidas.sieber
2023-04-21 10:06
It works with: `->addCustomProviderHeader('Authorization', 'Bearer <value>')`
Which I found here in line 41: https://github.com/pact-foundation/pact-php/blob/master/tests/PhpPact/Standalone/ProviderVerifier/VerifierTest.php.
yousafn
2023-04-27 20:46
:yolo: 'ed the above PR, sorry the above tests have caused red pipelines for so long
vaidas.sieber
2023-06-06 10:17
Hi, I use pact-php and encounter the following issue during the provider verification:
```http://console.INFO: Verifying PACT with script:
/srv/api/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/../../../../pact/bin/pact-provider-verifier [...]
1 / 1 (100%)
There was 1 error:
1) Tests\Pact\PactVerifyTest::testPactVerifyConsumer
Amp\Process\ProcessException: Could not determine PID
/srv/api/vendor/amphp/process/lib/Internal/Posix/Runner.php:56
/srv/api/vendor/amphp/amp/lib/Loop/NativeDriver.php:327
/srv/api/vendor/amphp/amp/lib/Loop/NativeDriver.php:124
/srv/api/vendor/amphp/amp/lib/Loop/Driver.php:138
/srv/api/vendor/amphp/amp/lib/Loop/Driver.php:72
/srv/api/vendor/amphp/amp/lib/Loop.php:95
/srv/api/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Runner/ProcessRunner.php:138 // https://github.com/pact-foundation/pact-php/blob/master/src/PhpPact/Standalone/Runner/ProcessRunner.php
/srv/api/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/ProviderVerifier/VerifierProcess.php:77
/srv/api/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/ProviderVerifier/Verifier.php:277
/srv/api/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/ProviderVerifier/Verifier.php:217
/srv/api/tests/Pact/tests/PactVerifyTest.php:69 // $verifier->verifyAll();```
Similar to https://github.com/amphp/process/issues/44 and reproducible like so:
```\Amp\Loop::run(function() {
$process = new \Amp\Process\Process(__DIR__.'/../../../vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/../../../../pact/bin/pact-provider-verifier');
yield $process->start();
yield $process->join();
});```
Is a verifier configuration missing or is it a bug in pact-php or amphp/process?
delboy1978uk
2023-06-20 07:55
@vaidas.sieber i think it is to do with the ruby installer, i use docker and my container doesn't have ruby, and using xdebug i saw that instead of a PID I got a bit of XML to do with the ruby installer
yousafn
2023-07-14 17:23
:elephant: PHP friends - A present for Friday.
Release 9.0.0 is out
? ARM64 for both Linux & MacOS is now natively supported by Pact PHP
? Linux Support for x86 platforms (32-bit) has been dropped
? The ruby standalone now runs the latest ruby 3.2.2 (big bump from a deprecated Ruby 2.4)
? Plus a few other fixes and enhancements from the community and maintainers.
? The CI Pipeline has dependabot hooked up, (its still a little bit flaky)
? Support for PHP 7.4 has been dropped. You should be on 8 by now though, surely :wink:
Whats next in store?
Oh Hi FFI :blobwave:
https://github.com/pact-foundation/pact-php/issues/262
mike.lovely
2023-07-17 12:36
Hello. I'm trying out pact for the first time and I can't seem to get a basic example working. I am getting:
```PhpPact\Standalone\Exception\HealthCheckFailedException: Failed to make connection to Mock Server in 100 attempts```
Here is my test setup:
```private \PhpPact\Standalone\MockService\MockServer $mockServer;
private \PhpPact\Standalone\MockService\MockServerEnvConfig $config;
public function setUp(): void
{
$this->config = new \PhpPact\Standalone\MockService\MockServerEnvConfig();
$this->config->setCors(true);
$this->config->setLog('file.log');
$this->mockServer = new \PhpPact\Standalone\MockService\MockServer($this->config);
$this->mockServer->start();
}
public function tearDown(): void
{
// Stop the Pact Mock Server
$this->mockServer->stop();
}```
I would paste the whole test but this fails during the set-up even before I get to the test. Not sure what to try. This is running locally on PHP 8.2 but also fails when running on PHP 8.1 via a docker container. Is there something obvious (probably) I am missing here?
Here is my phpunit.xml
```<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" bootstrap="tests/bootstrap.php" executionOrder="depends,defects" beStrictAboutOutputDuringTests="true" failOnRisky="true" failOnWarning="true">
<testsuites>
<testsuite name="Contract">
<directory>./tests/contract/</directory>
</testsuite>
</testsuites>
<php>
<env name="PACT_MOCK_SERVER_HOST" value="localhost"/>
<env name="PACT_MOCK_SERVER_PORT" value="7200"/>
<env name="PACT_CONSUMER_NAME" value="ExampleOne"/>
<env name="PACT_PROVIDER_NAME" value="ExampleAPI"/>
</php>
<coverage>
<report>
<clover outputFile="clover.xml"/>
</report>
</coverage>
</phpunit>```
yousafn
2023-07-17 12:43
Hey Mike,
What os/arch are you running on, and what docker image have you tried?
If you drop into the pact-php repo and do `composer install` / `composer test` does that run for you?
mike.lovely
2023-07-17 14:33
Hey @yousafn. I can run composer test locally (osx). I get a timeout eventually:
```> phpunit --debug -c example/phpunit.all.xml
PHPUnit 9.6.10 by Sebastian Bergmann and contributors.
Test 'PhpPactTest\Broker\Service\BrokerHttpClientTest::testAllConsumerUrlsAreExtractedCorrectly' started
Test 'PhpPactTest\Broker\Service\BrokerHttpClientTest::testAllConsumerUrlsAreExtractedCorrectly' ended
Test 'PhpPactTest\Consumer\InteractionBuilderTest::testSimpleGet' started
[2023-07-17T14:25:49.583843+00:00] server.debug: start background command: /app/src/PhpPact/Standalone/Installer/Model/../../../../../bin/pact-ruby-standalone/bin/pact-mock-service service --consumer='someConsumer' --provider='someProvider' --pact-dir='./example/output//' --pact-file-write-mode=overwrite --host=localhost --port=7200 --cors=true --pact-specification-version=2.0.0 [] []
[2023-07-17T14:25:49.776588+00:00] server.debug: started process pid=35 [] []
Test 'PhpPactTest\Consumer\InteractionBuilderTest::testSimpleGet' ended
Stopping Process Id: 35
Test 'PhpPactTest\Consumer\InteractionBuilderTest::testPostWithBody' started
[2023-07-17T14:29:12.398424+00:00] server.debug: start background command: /app/src/PhpPact/Standalone/Installer/Model/../../../../../bin/pact-ruby-standalone/bin/pact-mock-service service --consumer='someConsumer' --provider='someProvider' --pact-dir='./example/output//' --pact-file-write-mode=overwrite --host=localhost --port=7200 --cors=true --pact-specification-version=2.0.0 [] []
[2023-07-17T14:29:12.409379+00:00] server.debug: started process pid=46 [] []
The following exception is caused by a process timeout
Check https://getcomposer.org/doc/06-config.md#process-timeout for details
In Process.php line 1204:
The process "phpunit --debug -c example/phpunit.all.xml" exceeded the timeout of 300 seconds.
test [--dev] [--no-dev] [--] [<args>...]```
mike.lovely
2023-07-17 14:35
Sorry, not locally! Actually I am using a docker image to do this:
```docker run --rm --interactive --tty --volume $PWD:/app composer test```
mike.lovely
2023-07-17 16:15
Thanks :slightly_smiling_face: I ran the above using the official composer image:
https://hub.docker.com/_/composer
yousafn
2023-07-17 16:23
So looking at the tags it looks like an alpine base image
you?ll need some extra dependencies to run pact-php due to the ruby runtime requiring glibc
https://github.com/pact-foundation/pact-php/issues/314#issuecomment-1572288435
https://github.com/pact-foundation/pact-ruby-standalone/wiki/Using-the-pact-ruby-standalone-with-Alpine-Linux-Docker
https://docs.pact.io/docker#running-pact-on-docker
yousafn
2023-07-18 18:05
Hey @tien.xuan.vo,
Managed to get some time to spend on pact-php, over the last few days, have a PR targeting the `ffi` branch, there are some comments in there for you regarding whether you want to raise your own PR with the consolidated changes :slightly_smiling_face:
Thanks again for all your amazing contribution efforts
matt.fellows
2023-07-18 22:56
I?ve been watching all of the activity, and it?s like being at the centre of a tornado :tornado:
mike.lovely
2023-07-19 13:02
@yousafn Is there anything I need to do in particular to get my output file to be a collection of interactions? At the moment, each test seems to be overwriting the previous. I thought maybe using the `<extension class="PhpPact\Consumer\Listener\PactTestListener">` in my phpunit.xml but that doesn't seem to work with my version of phpunit (9.5.28).
At the end of each test should I be calling $builder->writePact() or finalize() or neither?
I'm not using pact-broker just yet. I am building up to that. I'm still just trying to get a poc working here.
yousafn
2023-07-19 13:17
was about to mention that and great, starting a poc without the broker is a great first step :+1:
alex.makdessi
2023-07-21 07:55
Hello @yousafn, except from the PHP7.4 support dropped, is there any migration guide from pact8 to pact9 ?
alex.makdessi
2023-07-21 08:11
nvm, I found this file: https://github.com/pact-foundation/pact-php/blob/966934c06a968ef52d9c3abde949654dc81e86a3/UPGRADE-9.0.md :slightly_smiling_face:
But it's not yet on 9.0
yousafn
2023-07-21 09:19
hello, that is for a different branch with the pact ffi.
9.0.0 should be largely a no op i think for your upgrade as long as you aren?t on php 7 or using linux 32bit
br.holanda15
2023-08-10 13:28
Hey guys, I'm trying to publish my contracts to `https://test.pactflow.io` as a test, but I got this error `PactBroker::Client::Hal::ErrorResponseReturned - Error making request to https://test.pactflow.io status=401`
Does anyone know how to make it work to publish my contracts? I'm running this command inside my container:
``` docker run --rm \
-v /var/www/bff_freights/pacts:/pacts \
-e https://test.pactflow.io \
-e dXfltyFMgNOFZAxr8io9wJ37iUpY42M \
-e O5AIZWxelWbLvqMd8PkAVycBJh2Psyg1 \
pactfoundation/pact-cli:latest \
publish \
/pacts \
--broker-base-url https://test.pactflow.io \
--consumer-app-version 1.0.0```
yousafn
2023-08-10 13:38
you need to name the env vars you are passing into docker PACT_BROKER_TOKEN=xyz
br.holanda15
2023-08-14 19:04
Hey guys, It's me again, now I'm trying to run my contract test with other branch, but I got this error:
``` GuzzleHttp\Exception\ServerException: Server error: `GET http://localhost:7200/interactions/verification` resulted in a `500 Internal Server Error` response:
? Actual interactions do not match expected interactions for mock MockService```
I have pact installed in my composer.json, and my .env.test with the environments, what should i do?:thinking_face:
matt.fellows
2023-08-14 21:32
Is there a log file or more detail in the output?it should tell you what was wrong with your request
It looks like the request doesn't match what you said
br.holanda15
2023-08-14 22:09
I added the PACT_LOG in my .env.test, but returned this error connection
`PhpPact\Standalone\Exception\HealthCheckFailedException: Failed to make connection to Mock Server in 10 attempts.`
matt.fellows
2023-08-14 23:58
Try setting the host to `127.0.0.1` - sometimes `localhost` resolves to an IPv6 address
br.holanda15
2023-08-15 12:05
Hmm, I changed to 127.0.0.1 , got the same error..I found in channel a similar problem, and I added this code to my Dockerfile
```ENV GLIBC_VERSION=2.35-r0
RUN apk --no-cache add gcompat bash \
&& wget -O /etc/apk/keys/sgerrand.rsa.pub -q https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub \
&& wget -q https://github.com/sgerrand/alpine-pkg-glibc/releases/download/${GLIBC_VERSION}/glibc-${GLIBC_VERSION}.apk \
&& apk --no-cache --force-overwrite add glibc-${GLIBC_VERSION}.apk```
Maybe that's not enough anymore :disappointed:
yousafn
2023-08-15 12:06
I am not sure pact-php 8.1 works with phpunit 10, the 9.x release explicitly had a PR that limited it to not working with 10.x
br.holanda15
2023-08-15 12:08
Ok, I'll try to downgrade the phpunit version,then I'll try to run pact again:thinking_face:
matt.fellows
2023-08-15 12:09
You can also try running the `pact-mock-service` command you see in that output manually, and seeing what happens. If it doesn?t start, it?s probably a good place to start debugging
yousafn
2023-08-15 12:10
https://github.com/pact-foundation/pact-ruby-standalone/issues/96#issuecomment-1528683353
glibc didn?t work for me installing directly, I used `gcompat` and `libccompat`
Matts suggestion to run it from the bin folder directly is a good idea just to check the output outside of php and check the service can start up
br.holanda15
2023-08-15 12:15
Thanks, guys, I'm gonna try this suggestion and come back later to give feedback.
br.holanda15
2023-08-16 13:07
Hey guys, I was debbuging and found the full message for the error.
```Actual interactions do not match expected interactions for mock MockService.
Missing requests:
POST /freights
See standard out/err for details```
Where do I get this out/err in pact?
yousafn
2023-08-16 17:39
I think that just means to the terminal (stdout and stderr are outputs)
that sounds like the mock server is working but your code under test didn?t make a request before the mock was verified, therefore it is saying it received no requests matching your interaction setup.
br.holanda15
2023-08-16 20:20
I added the request to mock server and It worked, by the way this step was at doc basic usage consumer too. Thanks guys.
``` $client = new Client();
$url = "http://{$config->getHost()}:{$config->getPort()}/freights";
$client->post($url, [
'json' => $engineRequest,
]);```
matt.fellows
2023-08-16 21:55
> Hey guys, I was debbuging and found the full message for the error.
what did you have to do to see that message? That?s the key thing a user would need to see to understand why their test failed, so it should hopefully be obvious. If it?s not, I think it should be fixed
br.holanda15
2023-08-21 17:19
He guys, I'm trying to write pacts in my pacts folder with a mock-service container, the test runs sucessfully, but any pact file json is generated inside my folder, here is my container:
``` setup-mock-service:
image: pactfoundation/pact-cli:latest
container_name: pact-mock
volumes:
- /pacts:/pacts
ports:
- "7200:7200"
command: mock-service --consumer openapi-freight-bff --provider ms-freight -p 7200 --host 0.0.0.0 --pact-dir /pacts
networks:
- openapi```
Am I missing any flag or config?
matt.fellows
2023-08-21 22:57
something is not right, as it wants a relative `./pacts` folder. Maybe the args aren?t coming in right?
br.holanda15
2023-08-22 18:27
Hello guys, It'me again, one question, this doc https://github.com/pact-foundation/pact-php/#provider-verification is update ? Because I got an error from undefined method, and when I searched into VerifierConfig I could find any method..
yousafn
2023-08-22 18:32
method is here
https://github.com/pact-foundation/pact-php/blob/e222a002bcb40519ee484092674093a00bac6ec8/src/PhpPact/Standalone/ProviderVerifier/Model/VerifierConfig.php#L118
used in this example
https://github.com/pact-foundation/pact-php/blob/e222a002bcb40519ee484092674093a00bac6ec8/example/tests/Provider/PactVerifyTest.php#L47
br.holanda15
2023-08-23 12:31
I found the error, I was using version 10.0 beta from pact-php, I think the stable version is 9.0.0, I changed it in my composer.json.Now I got a new error ashashahs, It seems the executable bin pact-provider-verifier does not exist.
yousafn
2023-08-23 12:53
the readme for the 10.x-beta in on the `ffi` branch.
a composer install will download the standalone binaries as long as its enabled, it will ask you for the first time, to allow downloads (its a composer thing)
br.holanda15
2023-08-24 20:16
Hey, I came back, ashahs. Now I installed the pact again via composer, but I got the same error, I visualized inside the vendor/pact-foundation/pact-php/pact/bin the binary, but somehow It didn't work, Is there any step that I missed?
br.holanda15
2023-08-29 12:18
Solved this problem, I should have installed bash in my container, I was using only sh
yousafn
2023-08-29 12:24
Ahh so that is a known issue re: bash. I solved it in the traveling-ruby source, but the changes need to be applied to pact-ruby-standalone, for it to be fully sh compliant and not require bash
https://github.com/pact-foundation/pact-ruby-standalone/issues/40
with guidance provided here
https://github.com/pact-foundation/pact-ruby-standalone/wiki/Using-the-pact-ruby-standalone-with-Alpine-Linux-Docker
https://docs.pact.io/docker#for-pact-implementations-that-use-the-ruby-shared-core-1
1. We can remove bash from the requirements, post resolving of the linked issue
2. It may be prudent to update the main branch for pact-php with a link to the alpine guidance links above.
a. https://github.com/pact-foundation/pact-php/#installation
shayanadc
2023-08-30 11:47
I am writing my first contract test with Pact locally:
```$request = new ConsumerRequest();
$request
->setMethod('GET')
->setPath("person")
->addHeader('Accept', 'application/json');
$response = new ProviderResponse();
$response
->setStatus(200)
->addHeader('Content-Type', 'application/json')
->setBody([]);
$config = new MockServerEnvConfig();
$builder = new InteractionBuilder($config);
$builder->given("list of person")
->uponReceiving('A get request to /person/{id}')
->with($request)
->willRespondWith($response);
$this->assertTrue($builder->verify());```
After running Phpunit, I get this error :
`GuzzleHttp\Exception\ConnectException: cURL error 6: Could not resolve host: person (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)`
it seems my connection with Pact broker on my local is not established but I check my connection and everything seem fine
shayanadc
2023-08-30 11:57
How can I check my pack broker on my local
I have access to http://localhost:1234/
but the response for person is:
```{"message":"No interaction found for GET /person","interaction_diffs":[{"description":"A get request to /person/{id}","provider_state":"list of person","headers":{"Accept":{"EXPECTED":"application/json","ACTUAL":"text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7"}}}]}```
matt.fellows
2023-08-30 11:58
for local pact tests, there is no broker.
1. Write and execute consumer test (produces pact file)
2. Publish pact file to broker
3. Verify pact tests with provider (pulls pacts from broker)
matt.fellows
2023-08-30 11:59
the error in the screen shot means you?re not sending any requests to the mock server
matt.fellows
2023-08-30 12:01
it is, but localhost:1234 is not a pact broker (it looks like the pact mock service)
2023-08-30 12:03
Here are a number of useful hands-on labs that teach all of the key concepts: https://docs.pactflow.io/docs/workshops and https://docs.pact.io/implementation_guides/workshops
matt.fellows
2023-08-30 12:03
I?d honestly start with the tutorials on PactFlow if you?re not familiar. The JS in browser killercoda should get you across the concepts quickly
br.holanda15
2023-09-04 17:14
Hey guys, It's me again. Did you guys have any problem with the missed bin folder in Pact when downloading with composer ? I am trying to verify my contract stored in one Pact Broker, But when I start the command, the bin file is not found.
br.holanda15
2023-09-05 14:12
I found the error, I should allow to download the plugins from dependecies in the composer install, But now I got an error from provider-states-setup-url. How could I "prepare/code" this state provider in my application? I found some https://github.com/mattermack/pact-php-example in doc but they are out of date..
matt.fellows
2023-09-06 00:57
When setting up the testing of a provider you will also need to setup the management of these provider states. The Pact verifier does this by making additional HTTP requests to the `--provider-states-setup-url` you provide. This URL could be on the provider application or a separate one. Some strategies for managing state include:
? Having endpoints in your application that are not active in production that create and delete your datastore state
? A separate application that has access to the same datastore to create and delete, like a separate App Engine module or Docker container pointing to the same datastore
? A standalone application that can start and stop the other server with different datastore states
So, TL;DR - you need to register a new route e.g. `/_pact/provider-states` that will receive requests from Pact during verification. In that route, you should do what is needed to setup the state
br.holanda15
2023-09-09 14:57
Hmm, so in this step I must implement an endpoint that returns the response registered in my contract that is stored in my Pact Broker? When I changed the provider-base-url to localhost:80 I didn't get this error, Is there an explanation for this situation? In this port, It's running an API with Docker.
matt.fellows
2023-09-11 02:21
the explanation is that, presumably, port `80` is where your API is running and the Pact test is able to communicate to port `80` and check that your endpoints match the contract
br.holanda15
2023-09-12 11:50
I am confused about how to implement and endpoint if I decide to change my base provider url in the code, But I think I understand for now. ahshashas
br.holanda15
2023-10-04 22:35
Hey guys, It's me again, I stuck in one situation. When I publish a new contract in my broker as a test, adding one input in request and other in response, when my provider verify the contract, I was expecting some error mentioning this inputs that my provider does not apply yet ( just to know, we are testing the flow in contract test), but instead I got this error :
``` "exception": {
"class": "RSpec::Expectations::ExpectationNotMetError",
"actualBody": {
"message": "Error to get company simplify data"
},
"differences": [
{
"description": "Could not find key \"data\" (keys present are: message) at $"
}```
But in my response there is a key `data` :
```{
"status": 201,
"body": {
"data": {
"track_response": "track_response",THIS WAS THE INPUT ADDED```
Is this error generic or really reference to the key data in my response ?:thinking_face:
matt.fellows
2023-10-05 02:11
where are you getting this exception? This should be hidden from you in PHP.
What do the logs say? (you should be able to generate a DEBUG log to file with what it actually got)
according to the error though, clearly the response was not what you thought (see `actualBody`). What makes you think your API isn?t returning the error?
br.holanda15
2023-10-05 17:46
I got this from Pact-Broker when I runned the test, but I retried the test and It "worked", now It's returning the error mentioning the `track_response` .
Thanks Matt.
br.holanda15
2023-10-23 18:53
Hey guys, What do you mean when said "This feature is preliminary as the Pact community as a whole is flushing this out." at doc. Is there any plan to remove message support to Pact PHP? Another question, when said "Both the provider and consumer side make heavy use of lambda functions.", if I want to test my apps that implement event-driven, Why should I specifically use lambda function? Because for HTTP synchronous requests I add my contract test like one unit test. I got confused in that part.
matt.fellows
2023-10-23 23:53
That should be updated. It?s certainly stable.
> Why should I specifically use lambda function? Because for HTTP synchronous requests I add my contract test like one unit test. I got confused in that part.
if you think about this, it will make sense. With HTTP, it?s a single standard - so a mock service for it and a mock client for it is easy to create in Pact.
With messages, there are literally thousands of protocols and standards. Pact could not possibly create a reliable mock server/client for all of them.
So we need to abstract this away. see https://docs.pact.io/getting_started/how_pact_works#non-http-testing-message-pact for how it works.
cc: @tien.xuan.vo
2023-10-24 16:18
This message was deleted.
br.holanda15
2023-10-25 17:39
Did you add the config for test in any .env file ? Adding the port and host for the test. :thinking_face:
br.holanda15
2023-10-25 17:46
I think I've got the reason why we should abstract the technology and the implementation to focus on the content of the message that we will consume or produce.
br.holanda15
2023-10-25 18:41
But looking forward to the example in pact-php.
First, we start the `$builder` passing the `self::$config` that we created in our `setUpBeforeClass()`.
Then we create the `$contents` which I guess It's the content of the message that we suppose we will consume, and we create our `$metadata` that represents a kind of name of _queue, topic, routing_key_, depending on which technology we are using in *event-driven architecture.*
Continuing, we instantianted our `$builder` passing `$metadata` and `$contents`.
We have one part that is not clear to me about how it really works, creating our `$consumerMessage` and then attributing to `$callback` with its method that call consume the message ( Is it implementation, the Adapter part? ). Then the `$builder` executes the `setCallback()` and we verify in the end...I mean, suppose I have one method called `publish()` in one _*Interface PublisherInterface*_(Port), and one class with _*KafkaPublisher(*_Adapter_*)*_ implements this Interface, Should I pass this publish method in the place of 'ProcessText' like the example?
And what about Pact Broker? Should we publish like HTTP use cause?
lepdiana01
2023-10-25 20:21
This is the linux error I'm receiving
```qemu-x86_64: Could not open '/lib64/1d-linux-x86-64.so.2': No such file or directory```
joshua.ellis
2023-10-29 21:03
@bethskurrie Could we silence GitHub notifications to just notify of releases on this channel as well?
br.holanda15
2023-10-30 12:31
Hey guys, If there is someone who can clarify the flow of testing messages with PHP I would aprrecitate it, asahshasa :eyes:
tien.xuan.vo
2023-10-30 14:25
Hi, I'm Tien, I'm contributor of version 10 (not released yet). I'm not maintainer of version <=9, he is very busy.
I'll try to answer this question from what I understand:
> Should I pass this publish method in the place of 'ProcessText' like the example?
I think the `publish` method is belong to provider side (publishing message to message broker). You shouldn't pass that method in place of 'ProcessText' in this example. This example test is only for consumer side (handling message that has been subscribed from message broker).
> And what about Pact Broker? Should we publish like HTTP use cause?
I think you should publish pact file to Pact Broker once the pact file is written (verify success).
br.holanda15
2023-10-30 20:44
Thanks, guys, I was changing the concept from the publisher/provider side, and now I understand Why in the consumer part we simulate the process with callback, basically It represents what you are going to do with the message that you received. Is that right? ashasha.
tien.xuan.vo
2023-10-31 02:36
I would like to self-merge pull requests to `ffi` branch that has 1 approval to speed up development on that branch
tien.xuan.vo
2023-10-31 03:26
Cirrus CI: Failed to start an instance: FAILED_PRECONDITION: Monthly free compute limit exceeded!
joshua.ellis
2023-10-31 03:45
No, unfortunately there really isn't :disappointed: On the plus side, it's 31 October, so it should be resolved very soon!
br.holanda15
2023-11-08 12:08
Hello guys, I want to clarify one point. Can we use the PhpPact\Consumer\Matcher\Matcher inside the content in the `$contents->song` from our ConsumerMessage example? Because I don't know exactly what is the content, I am worried about the schema of the message, like the song attribute.
tien.xuan.vo
2023-11-08 12:32
I'm not sure about version <=9. I think you can. But I can be wrong.
In version 10, in theory you can use almost any matching rules or generators in the message content. For metadata you can't (for now)
matt.fellows
2023-11-08 22:50
yes you should be able to. Matchers should work in any body whether message or HTTP
joshua.ellis
2023-11-29 22:36
@bethskurrie Circling back to this if possible. Tien has been doing amazing work, but the notifications unfortunately drown out this channel with noise :disappointed:
matt.fellows
2023-12-11 10:07
:clap: awesome work @tien.xuan.vo, so nice to have these kinds of feedback also :heart: https://github.com/pact-foundation/pact-php/issues/377
tien.xuan.vo
2023-12-11 10:10
:thankyou: I love that kind of feedback also. I will response with a thank later tonight
joshua.ellis
2023-12-18 03:31
@matt.fellows Is this something you could do? With all of Tien's activity, this channel is not very usable :disappointed:
matt.fellows
2023-12-18 04:02
BTW we have two channels for Pact JS - #pact-js and #pact-js-development
2023-12-18 04:03
Unsubscribed from https://github.com/pact-foundation/pact-php
joshua.ellis
2023-12-18 04:04
Possible, though personally I don't see the use of a development channel (over, for example, just seeing the activity on GitHub). But others may use this differently
joshua.ellis
2023-12-18 04:06
I think subscribing to release would be good, I don't think we need anything else for this channel :slightly_smiling_face:
2023-12-18 04:06
:white_check_mark: Subscribed to https://github.com/pact-foundation/pact-php. This channel will receive notifications for `issues`, `pulls`, `commits`, `releases`, `deployments`
2023-12-18 04:08
This channel will receive notifications from https://github.com/pact-foundation/pact-php for: `issues`, `commits`, `releases`, `deployments`
2023-12-18 04:08
This channel will receive notifications from https://github.com/pact-foundation/pact-php for: `commits`, `releases`, `deployments`
2023-12-18 04:08
This channel will receive notifications from https://github.com/pact-foundation/pact-php for: `releases`, `deployments`
2023-12-18 04:08
This channel will receive notifications from https://github.com/pact-foundation/pact-php for: `releases`
matt.fellows
2023-12-18 04:08
OK, I had to unsubscribe to the ones I didn?t want, rather than subscribe to the one I did
joshua.ellis
2023-12-18 04:08
hahaha, it certainly did not do what was on the box :laughing: I remember Beth having to do the manual unsubscribe for each as well
lewiscowles
2023-12-18 10:23
@matt.fellows sorry, I'd asked that @tien.xuan.vo break down a large commit into more easily reviewable chunks.
lewiscowles
2023-12-18 10:24
@tien.xuan.vo you are truly the hero of Pact for PHP; I just wanted to publicly thank you for your patience; your willingness to make edits, or provide explanations, and for trying ideas. I Hope you and your loved ones have a great rest of the year!
lewiscowles
2023-12-18 10:26
All I've really done is respond, ad-hoc to requests. If anything I feel like I've been holding back @tien.xuan.vo who is the real deal.
matt.fellows
2023-12-18 21:56
No worries at all, totally reasonable suggestion given the huge amount of change going on. Thanks so much for reviewing, it is truly very much appreciated :pray:
lewiscowles
2023-12-19 11:08
Just seen this thread. The last one is particularly troubling as it shouldn't be possible once we only use Rust and normal PHP
> The error code -1073741819 you're encountering, also known as 0xC0000005 or "Access Violation," is a common error in C and C++ programs. It indicates that *your program attempted to access memory that it was not allowed to access, resulting in a segmentation fault*.
tien.xuan.vo
2023-12-20 03:07
On version 10, I don't have these errors recently. But I got another error, once for a while:
```There was 1 error:
1) MatchersProvider\Tests\PactVerifyTest::testPactVerifyConsumer
Symfony\Component\Process\Exception\ProcessTimedOutException: The process "'php' '-S' '127.0.0.1:7202' '-t' '/Users/runner/work/pact-php/pact-php/example/matchers/provider/tests/../public/'" exceeded the timeout of 60 seconds. ```
lewiscowles
2023-12-20 10:39
This is part of why the switch to FFI has been so impactful. Not just faster, but avoiding sub-process calls.
joshua.ellis
2023-12-28 22:14
And so many thanks to yourself for all of the work you've been doing! Hope you have a great Christmas, and wishing you all the best for the new year!
yousafn
2024-01-09 08:04
dude - christmas release :christmas_tree: nice! taking a leaf out of rubies book!
thank you for absolutely smashing it this year, hope you?ve enjoyed the journey
yousafn
2024-01-09 08:08
so kind, and I fully agree. We are appreciative for your really thorough reviews, and suggestions. It makes me well happy seeing everyone so supportive and enthusiastic about helping others
mahesh.damavarapu
2024-01-12 07:09
Hello All, Is there any examples on publishing contract to pactbroker in PHP. I see Publish related code base is available in https://github.com/pact-foundation/pact-php/blob/master/src/PhpPact/Standalone/Broker/Broker.php#L206.
matt.fellows
2024-01-12 09:46
The recommendation is to use https://docs.pact.io/implementation_guides/cli#pact-broker-cli
f.barril
2024-01-12 18:05
Do I need the PactTestLinstener.php if I am using pact only for messages/events? I am not using for http requests
f.barril
2024-01-12 18:10
nother thing, I am getting this error
``` /app/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/Model/../../../../../bin/pact-ruby-standalone/bin/pact-provider-verifier: not found```
matt.fellows
2024-01-14 10:01
Sounds like a problem with your install. How have you set it up? Any errors on the logs when installing it? What OS is it? Is it running docker and Alpine?
f.barril
2024-01-14 18:13
I used the command on the repo , I am running inside a docker container. I am using a Mac m1
matt.fellows
2024-01-14 21:20
What command? Weekday docker container? How are you getting the code into the container?
See howtoask
2024-01-14 21:21
Please see this page for some tips on how to ask for help to get the best response from the community https://docs.pact.io/help/how_to_ask_for_help
f.barril
2024-01-15 11:50
my bad I could have added more info sorry
i am using a mac m1
I am running the following command
```php -d memory_limit=-1 -d xdebug.mode=off /app/vendor/bin/phpunit```
inside a docker container with php 8.2
no error logs when installing
f.barril
2024-01-15 16:53
I've installed with the command available on repo
```$ composer require pact-foundation/pact-php --dev```
f.barril
2024-01-15 17:36
is there any way to increase logs to debug ? I am getting an error with no useful info
f.barril
2024-01-15 17:37
```
1) Tests\Contract\PatientCreatedTest::testProcess
Exception: Pact failed to validate. Exit code: 1
/app/vendor/pact-foundation/pact-php/src/PhpPact/Provider/MessageVerifier.php:187
/app/vendor/amphp/amp/lib/Coroutine.php:118
/app/vendor/amphp/amp/lib/Internal/Placeholder.php:149
/app/vendor/amphp/amp/lib/Deferred.php:53
/app/vendor/amphp/byte-stream/lib/ResourceInputStream.php:109
/app/vendor/amphp/amp/lib/Loop/Driver.php:119
/app/vendor/amphp/amp/lib/Loop/Driver.php:72
/app/vendor/amphp/amp/lib/Loop.php:95
/app/vendor/pact-foundation/pact-php/src/PhpPact/Provider/MessageVerifier.php:194
/app/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/ProviderVerifier/Verifier.php:162
/app/tests/contract/PatientCreatedTest.php:60```
yousafn
2024-01-15 20:01
I believe you can set the env var `PACT_LOGLEVEL` to control the output level
f.barril
2024-01-16 09:57
any idea what may be causing this error?
```PHPUnit 9.6.13 by Sebastian Bergmann and contributors.
[2024-01-16T09:56:23.899503+00:00] server.debug: Starting [] []
[2024-01-16T09:56:23.900681+00:00] server.warning: Running in production with assertions enabled is not recommended; it has a negative impact on performance. Disable assertions in php.ini (zend.assertions = -1) for best performance or set the debug mode option to hide this warning. [] []
[2024-01-16T09:56:23.900848+00:00] server.warning: The 'xdebug' extension is loaded, which has a major impact on performance. [] []
[2024-01-16T09:56:23.902679+00:00] server.debug: Started [] []
[2024-01-16T09:56:23.902946+00:00] http://server.info: Listening on http://127.0.0.1:7201/ [] []
[2024-01-16T09:56:31.117009+00:00] server.warning: /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-1.63.0/lib/pact/provider/configuration/service_provider_dsl.rb:88:in `validate': Please set the app_version when publish_verification_results is true (Pact::Provider::Configuration::Error)
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-1.63.0/lib/pact/provider/configuration/service_provider_dsl.rb:80:in `finalize'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-support-1.19.0/lib/pact/shared/dsl.rb:66:in `build'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-1.63.0/lib/pact/provider/configuration/dsl.rb:10:in `service_provider'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:83:in `configure_service_provider'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:196:in `reset_pact_configuration'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:180:in `verify_pact'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:51:in `block in pacts_pass_verification?'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:50:in `collect'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:50:in `pacts_pass_verification?'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:42:in `call'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/app.rb:35:in `call'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/cli/verify.rb:49:in `verify'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor/command.rb:27:in `run'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor/invocation.rb:127:in `invoke_command'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor.rb:392:in `dispatch'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/thor-1.2.2/lib/thor/base.rb:485:in `start'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/vendor/ruby/3.2.0/gems/pact-provider-verifier-1.36.1/lib/pact/provider_verifier/cli/custom_thor.rb:17:in `start'
from /app/vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/lib/app/pact-provider-verifier.rb:33:in `<main>'
[] []
E 1 / 1 (100%)INFO: Fetching pacts for patient.created-provider from http://pact-broker:9292 with the selection criteria:
Time: 00:07.310, Memory: 40.50 MB
There was 1 error:
1) Tests\Contract\PatientCreatedTest::testProcess
Exception: Pact failed to validate. Exit code: 1
/app/vendor/pact-foundation/pact-php/src/PhpPact/Provider/MessageVerifier.php:211
/app/vendor/amphp/amp/lib/Coroutine.php:118
/app/vendor/amphp/amp/lib/Internal/Placeholder.php:149
/app/vendor/amphp/amp/lib/Deferred.php:53
/app/vendor/amphp/byte-stream/lib/ResourceInputStream.php:109
/app/vendor/amphp/amp/lib/Loop/Driver.php:119
/app/vendor/amphp/amp/lib/Loop/Driver.php:72
/app/vendor/amphp/amp/lib/Loop.php:95
/app/vendor/pact-foundation/pact-php/src/PhpPact/Provider/MessageVerifier.php:219
/app/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/ProviderVerifier/Verifier.php:162
/app/tests/contract/PatientCreatedTest.php:62
ERRORS!
Tests: 1, Assertions: 0, Errors: 1.```
yousafn
2024-01-16 12:16
1) warning as publish verification results set but no version provided
2) looks like we are searching for patient.created-provider provider, but there are no consumer versions shown in your output so it looks to me as it cant find contracts to validate from the broker
can you share the test and test setup?
f.barril
2024-01-16 14:53
it's working now :pray: it was missing
```->setProviderBaseUrl(new Uri('http://localhost:7201')) // Url of the Provider to verify.```
f.barril
2024-02-06 10:59
Hi, any example/idea how I can access the git commit hash within the code? In JS was easy, I just used `git rev-parse HEAD` inside the package.json
matt.fellows
2024-02-06 11:10
Can you just do a similar thing with PHP?s `shell-exec` (or another comparable function): https://www.php.net/manual/en/function.shell-exec.php
f.barril
2024-02-06 11:48
How can i run pact-broker can-i-deploy? I am trying calling it directly inside a docker container with php 8 but it says `bash: pact-broker: command not found` . Do you have any example? I could not find any example in the github repo.
f.barril
2024-02-06 14:34
If I run `vendor/pact-foundation/pact-php/bin/pact-ruby-standalone/bin/pact-broker` it works
f.barril
2024-02-06 15:04
also, the can-i-deploy should be a script on composer.json, should be a php artisan command (if using laravel) ? what's the best practice?
matt.fellows
2024-02-06 22:32
there is no ?best practice??, it really depends on how you like to setup your CI/CD practices. All of the `pact-broker` commands are separate to your test runs IMO, and should be run in a separate step
f.barril
2024-02-08 10:19
I am trying to use the broker class, and when I run `$broker->canIDeploy()` I get the following error `Error Output: Control character error, possibly incorrectly encoded` even tough the verification was successful because I can see in the error trace. It fails on this line
```return \json_decode($runner->getOutput(), true, 512, JSON_THROW_ON_ERROR);```
of the `vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Broker/Broker.php` class.
The output that it's trying to decode is the result of the verification :arrow_down:
```"Computer says yes \o/
CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? | RESULT#
---------------------|------------|--------------------|------------|----------|--------
yyy | 33be842... | xxx | 9bf90f7... | true | 1
VERIFICATION RESULTS
--------------------
1. http://pact-broker:9292/pacts/provider/xxx/consumer/yyy/pact-version/19acd2d758b93bc65608b5f24f18034369bab954/metadata/Y3ZuPTMzYmU4NDI"...```
yousafn
2024-02-08 10:21
Hey @f.barril
Interesting. can-i-deploy has a `--json` flag that can return the results as json, rather than the default table
https://github.com/pact-foundation/pact_broker-client?tab=readme-ov-file#can-i-deploy
Maybe it isn?t being passed. Assume this is pact-php v9?
f.barril
2024-02-08 10:30
this is my code, I am using v9
```$config = new BrokerConfig();
$config->setBrokerUri(newUri(env('PACT_BROKER_BASE_URL');
$config->setPacticipant('xxx');
$config->setVersion('1.0.0');
$broker = new Broker($config);
try {
$result = $broker->canIDeploy();```
yousafn
2024-02-08 10:36
I assume this should have a `--json` argument in this command.
https://github.com/pact-foundation/pact-php/blob/a4da1ff806baa708099fb193b5b11df5d7252ff5/src/PhpPact/Standalone/Broker/Broker.php#L23-L38
It looks like it is added to one command
https://github.com/pact-foundation/pact-php/blob/a4da1ff806baa708099fb193b5b11df5d7252ff5/src/PhpPact/Standalone/Broker/Broker.php#L176
but not others.
f.barril
2024-02-08 10:40
it works if I add the flag `'--output=json'` to the `canIDeploy` function. Do you want me to open a PR for this change?
yousafn
2024-02-08 11:37
not sure within pact-php, some of the client libraries have wrappers around the pact-cli tools (which are likely to ultimately be deprecated from the client libs), but usually lag in terms of features so the recommendation is to use the pact-cli tools directly
https://docs.pact.io/pact_broker/client_cli/readme#installation
They will also be available in your pact-php installation with v9.
`--latest` isn?t really recommended, it will print a large warning at you telling you that it is non deterministic
and tell you that you should be providing two things ideally, a version number and an environment you wish to deploy to.
yousafn
2024-02-08 11:39
ahh pact-php is forcing you to set a version there in the can-i-deploy command, so you can?t just provide `--latest`, but I?m not sure if you pass it the environment, the interface hasn?t been updated I don?t believe, since the environments feature came out in the cli tools.
you can with the cli tools, but with caveats that the tool with spit out :slightly_smiling_face:
yousafn
2024-02-08 14:28
I?ll leave it open overnight, in case there are any comments from others, otherwise I will look to get it out tomorrow
f.barril
2024-02-14 16:43
do you have any consumer example for messages? I only found examples for API requests
m.barbosa
2024-02-15 13:59
I'm trying to use the consumer for messages, my function expects to receive a class, but I'm getting a string. I'm using this example for my test.
https://github.com/pact-foundation/pact-php/tree/master/example#consumer-tests-for-message-processing
m.barbosa
2024-02-15 14:03
```<?php
declare(strict_types=1);
namespace Tests\Contract\Consumer;
use Exception;
use App\Events\SubmittedEvent;
use App\Listeners\SubmittedListener;
use PhpPact\Consumer\MessageBuilder;
use PhpPact\Standalone\PactConfigInterface;
use PhpPact\Standalone\PactMessage\PactMessageConfig;
use PHPUnit\Framework\TestCase;
/**
* Class SubmittedTest
*/
class SubmittedTest extends TestCase
{
private static PactConfigInterface $config;
public static function setUpBeforeClass(): void
{
parent::setUpBeforeClass();
self::$config = (new PactMessageConfig())
->setConsumer('api-consumer')
->setProvider('api-provider');
}
public static function tearDownAfterClass(): void
{
parent::tearDownAfterClass();
// build out brokerHttpService as your example
/*
$brokerHttpService = new BrokerHttpClient(new GuzzleClient(), new Uri($pactBrokerUri));
$brokerHttpService->publishJson($json, $consumerVersion);
$brokerHttpService->tag($this->mockServerConfig->getConsumer(), $consumerVersion, $tag);
*/
}
/**
* @throws \Exception
*/
public function testProcess()
{
$builder = new MessageBuilder(self::$config);
$formKey = 'f100';
$submittedUUID = 'submittedUuid';
$kit = 'kit1000';
$contents = new SubmittedEvent([
'form_key' => $formKey,
'submitted_uuid' => $submittedUUID,
'kit' => $kit
]);
$metadata = [];
$builder
->given('a new kit')
->expectsToReceive('a form submission event')
->withMetadata($metadata)
->withContent($contents);
// established mechanism to this via callbacks
$consumerMessage = new SubmittedListener();
$callback = [$consumerMessage, 'handleVersion1'];
$builder->setCallback($callback);
$builder->verify();
$this->assertTrue(true, 'Expects to reach this true statement by running verify()');
}
}```
m.barbosa
2024-02-15 14:05
```<?php
declare(strict_types=1);
namespace App\Listeners;
use App\Events\SubmittedEvent;
use App\Models\Form;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Support\Facades\Log;
final class SubmittedListener extends AbstractListener implements ShouldQueue
{
/**
* @param SubmittedEvent $event
*/
public function handleVersion1(SubmittedEvent $event)
{
if (empty($event->kit) || empty($event->submittedUUID)) {
return;
}
$form = Form::where('uuid', $event->submittedUUID)->first();
if ($form === null || !empty($form->kit)) {
return;
}
Log::info(sprintf('Assign kit %s to patient %s.', $event->kit, $form->uuid));
$form->update([
'kit' => $event->kit,
]);
}
}```
m.barbosa
2024-02-15 14:06
```formKey = $eventPayload['form_key'];
$this->submittedUUID = $eventPayload['submitted_uuid'];
$this->kit = $eventPayload['kit'];
}
}```
m.barbosa
2024-02-15 14:11
I received this error
```[2024-02-15T14:08:41.423121+00:00] server.debug: Process command: /app/vendor/pact-foundation/pact-php/src/PhpPact/Standalone/Installer/Model/../../../../../bin/pact-ruby-standalone/bin/pact-message reify '{"description":"a submission event","providerStates":[{"name":"a new kit","params":[]}],"contents":{"queue":"","formKey":"f100","submittedUUID":"submittedUuid","kit":"kit1000"}}' [] []
[2024-02-15T14:08:42.238957+00:00] server.debug: Exit code: 0 [] []
E
Time: 00:00.848, Memory: 40.50 MB
There was 1 error:
1) Tests\Contract\Consumer\SubmittedTest::testProcess
TypeError: App\Listeners\SubmittedListener::handleVersion1(): Argument #1 ($event) must be of type App\Events\SubmittedEvent, string given, called in /app/vendor/pact-foundation/pact-php/src/PhpPact/Consumer/MessageBuilder.php on line 133```
matt.fellows
2024-02-16 05:40
I may be misunderstanding the PHP interface here, but it?s not going to be sending typed objects into your callback, it?s going to be sending in the JSON payload you gave it
matt.fellows
2024-02-16 05:41
d.madureira
2024-02-19 14:53
*[Could not determine PID]*
I've been getting this error when trying to run my consumer test.
The broker is running and the test is very similar to other test I already have (that works).
d.madureira
2024-02-19 14:54
For future reference, this problem can be solved by wrapping your callback with a function.
Like this:
d.madureira
2024-02-19 16:37
*[Solution]*
It turns out this was being caused by a string escaping problem.
```$builder = new MessageBuilder(self::$config);
$builder
->given("an event's publishing")
->expectsToReceive("the event's payload")
[...]```
When either of `given()` or `expectsToReceive()` methods are called with a string containing quotes (even if they are escaped), they throw completely unrelated errors.
d.madureira
2024-02-19 16:37
That said, I'm not sure if this is documented and it's me who's messing up or if things are actually misbehaving. If the latter is true please let me know, I might be able to help!
