has joined #pact-node

@matt.fellows what's your thoughts on this security hole workaround?

has joined #pact-node

/github unsubscribe pact-foundation/pact-node commits

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

welp, that was easy :slightly_smiling_face:

:slightly_smiling_face:

@matt.fellows could you review this PR please?

has joined #pact-node

Will do @mboudreau

Likely this weekend, I'm unfortunately having to drive to my client at the moment, so no train time to do the things as I had before

It's really not big...

LGTM:rocket:

has joined #pact-node

has joined #pact-node

has joined #pact-node

@mboudreau haven?t changed anything recently have we?

@matt.fellows uploaded a file: https://pact-foundation.slack.com/files/U9UUY3CU9/FBR6MBQMC/screenshot.png

Weirdly, publish failed but build was green?

OK, looks like this was it. Man, lots of working for just bumping a version :smile:

jebus, security breach at npm?

I can create a new api key and put it in the repo if you don't know how

all good, it?s done sir

thanks :slightly_smiling_face:

:smile:

np

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

@mboudreau - would you mind if I finish off the `can-i-deploy` branch that you started in `pact-node`? I have some time to spend on it, but don't want to step on your toes

Go for it. I'm on vacation right now

has joined #pact-node

I'm just implementing verification of pacts on a new node based microservice, there are no pacts on my broker because the microservice is new and my tests fail because of it. Therefore I'm in a chicken and egg situation. I can't deploy my new provider microservice until I have a consumer, but I can't deploy my consumer microservice until I have a provider. Is there a way to not error if no pacts exist?

has joined #pact-node

@matt.fellows is there a more convenient way to access the `can-i-deploy` util (which belongs to pact-broker) than to use the `find ./ -name pact-broker` trick? maybe it can be easily symlinked as a binary for pact-node or something?

There is an issue in pact node to do just this.

But short answer is no

It should be pretty straightforward

@liran.tal You might find this useful: https://github.com/pact-foundation/pact-node/pull/106

has joined #pact-node

thanks @tjones, I?ll take a look

Should the `Verified` export from pact-node be able to work with a broker URL that is available on HTTP-only? Has this been tested?

Since I?m getting an issue of `Unable to find pacts for this provider` which I saw was opened recently too with regards to SSL and self-signed certs.

@liran.tal it definitely should work with http only. If it?s not that?s either an issue with the setup, or a bug in our code

I'm working with the pact broker docker setup, is there an easy way for me to debug what's going on? I'm pretty sure I spelled the provider just fine

hmm

probably the easiest way is to tail the logs, which I assume you?re doing? I think the default logs are set to `DEBUG` too, which should be pretty verbose

actually I?m not seeing anything from the broker container, only from nginx: `nginx_1 | 172.24.0.1 - - [07/Oct/2018:06:37:35 +0000] "GET / HTTP/1.1" 200 2118 "-" "-" "-"`

has joined #pact-node

hi all Facing an issue with pact verification, getting below error Pact verification failed! Actual interactions do not match expected interactions for mock MockService. I understand this is because the request is executed before the interactions were added however I have added done to my interactions, still getting this error

hi harsh, can you post a code sample? Kinda hard to debug if we don't see anything :stuck_out_tongue:

Hi @mboudreau, this is the relevant code, lt me know if you need to have a look at entire source file

?we?ll need the whole thing, and probably more

more importantly, the pact log file

Please let me know if you need more information

OK so the error in the pact log is telling you what went wrong: you haven?t hit the pact mock server at `/apigw/v1/register`

You code `fetchRegisteredServices` might be running, but presumably it hasn?t been configured to hit the Pact mock server (which you?ve configured to be running at `http://localhost:1234`).

Make your code configurable so that you can switch out the API endpoint from the live one to the mock one and you should be good

nope, it is running against the actual API endpoint

I am not mocking provider here

Yes, that?s why it?s failing

Pact needs to be the mock

ahh

:slightly_smiling_face:

thanks for the clarification

np

follow-up question is

Pact needs to be able to know what is going on, so that a) it can properly write the pact to file and b) to confirm your assumptions about your code are correct

I want this to run as part of CI, and there are many check-ins going on which will trigger these contract tests in parallel

how can I tell mock to use different port for each trigger?

is there a known solution for this?

there are plenty of ways to generate random ports

e.g. https://www.npmjs.com/package/get-port

is that what you mean?

is this the standard way of doing it in CI?

I am not sure about best practices, hence asking

well, one way is to always run within a docker container and use the same port (but don?t expose it to the host). This should prevent conflicts

the other is to grab a random port

ok, we are using docker so I will have to check how to achieve what you are saying with docker

is there a documentation for this?

Also, how to handle parameters in interactions?

After doing the change you suggested, I am getting below error

Expected "serviceName" but got "YxsrBDjrdYnE" at $.body.service_name

The error message is pretty clear - you expected `serviceName` but got something else

See https://github.com/pact-foundation/pact-js#matching

you mean query strings?

Thanks

np

if so, you want the `query` key (sibling of `status`, `path` etc.)

I have to run, but see how you go. There are lots of examples in the repo you might want to look through if running into issues, as well as previous issues

good luck!

Thanks a lot @matt.fellows

Again getting the same error with mock provider as well :disappointed:

First it logs missing interactions, however subsequently it logs that the matching request is found

it also writes a pact file

however tests are marked as failed

just because pact got the interaction doesn't mean the test will pass. It depends very much on your test code

my question is that why it is saying missing request

?

Can someone please guide me what I am missing here?

I have written a very straight forward expect condition to keep it simple

expect(res.status).to.equal(200)

still it is failing

It looks like your test code is calling verify before the test case runs. It seems to hit the mock server in the wrong sequence

I think the top level it block (that runs verify) is running before you're describe block. You also only ever register the interaction once at the top level, which looks to be incorrect. You probably want to group each test with it's own register and test assertion

Look at the examples in the repository for best practices in simplifying this setup

Any pointers to debug this error

Uncaught Error: Unhandled Promise Rejection: TypeError: re.exec is not a function

where is it being triggered?

I managed to figure this out, in response to one of the request I was using open api spec which was causing this issue.

Thanks for responding :slightly_smiling_face:

@mboudreau Did the publish work correctly? I can see it in the travis log, but not in npm. I thought npm publishes were immediate..

it says 6.20.0 for me :slightly_smiling_face:

I got the notification too

with regards to provider contract testing - I guess it seems redundant to do the pact verifier as part of a testing suite?? - there?s anyway one method that works through all the interactions (i.e: pact.verify()) - due to the above we need to manually add timeouts (i.e: jest.setTimeout(30000)) for the test case because to download the contracts, spin up the runner, and verify everything all in one assertion takes more time than is usually set for a test case. it might be just convenient to use a test framework if its already there and just wrap it but probably not adding any further value than that?

> - there?s anyway one method that works through all the interactions (i.e: pact.verify()) We have some ideas of how to improve this too, because it would be much nicer to get granular feedback on each of the tests. In fact, Pact Go does this (but it?s easier there, because _most_ people just use the in-build `testing` package unlike Node, where there are 100's of test fraameworks to support) > it might be just convenient to use a test framework if its already there and just wrap it but probably not adding any further value than that? I?m not sure I follow, could you perhaps give an example of what you mean?

about the first point with all the interactions - yeah that would be pretty interesting to be able to have a single test case for each interaction testing. thinking out loud, maybe pact can return an iterator of all interactions to verify, and then we can iterate it and build the test cases dynamically. maybe something like: ``` pact.verifierInteractions().forEach((interaction) => { test('interaction X', () => { interaction.verify() }) }); ``` would be great to see other alternatives too for this problem as the above isn?t ideal either.

in my second bullet I meant that because there?s a test framework, we can wrap the pact.verify() inside a test case and because it fails, the test framework will catch it, error out, set exit status code to non-zero etc. Although in general, I could just have a plain test.js file with no test framework to run pact.verify() and call it like `node test.js`

gotcha

has joined #pact-node

has joined #pact-node

has joined #pact-node

Hi, I am new to contract tests and I am trying to write contract tests in NodeJS. I am following pact documentation, which has 3 links for JS support. Three links talks little bit differently. Can you give me right link

@hima.sanagavarapu you can check the example projects in pact-js: https://github.com/pact-foundation/pact-js/tree/master/examples/ there are multiple types of checks to get you started with what you might be familiar more

and also welcome :slightly_smiling_face:

hey - just wondering if anyone is now successfully running pact-node stuff on docker alpine images? I'm still having issues with the standalone ruby not working

I've followed the steps in this issue https://github.com/pact-foundation/pact-js/issues/154 to add glibc to my alpine image but it hasn't helped

@matt.fellows any ideas?

Hey Nic, sorry I?ve been travelling with very intermittent/poor WiFi access. I?ll take a quick look now

no worries, I know this has come up before. last time I just ended up switching to a glibc based distro to get it working but we?re pushing this out to production now and people are unhappy with huge docker images kicking around.

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

hello! how am I supposed to use `latest` in `canDeploy()`? I?ve tried adding the participant and latest, but I keep getting ``` TypeError: Must provide the same number of pacticipant and version ``` ``` const checkProvider = { pactBroker: "http://localhost", pacticipant: ["service"], latest: ["f54201e8"], //tried true, "", "master" }; ``` and when I add the pacticipant version to the mix I get `Error: A version number and latest flag cannot both be specified for service`

hm, can you create a github issue? I can have a peek at it, but there might be something wrong with the code itself after a quick glance. Thanks.

will do it a bit later :slightly_smiling_face: cheers

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

Hi everyone, It might be weird question, but why you ignore `package-lock.json` file?

do you mean, why does pact-node not check it in?

has joined #pact-node

Yes, exactly.

I think historically it was an issue, there is probably evidence of this in our issues register. It might not be relevant now

Yeah, we were seeing issues with optional and peer dependencies not loading properly because npm failed to account for that in package-lock

Is it causing you issues now? It probably could be added back in now, as Michel has changed the way we install the package to be more cross-OS compatible. It was a constant pain point

yep, it's a good point, but it will only affect contributors though

I mean, even still, our package.json is extremely specific with versions

yep

I?m keen to understand if it _is_ causing issues

you mean the package-lock file?>

probably not anymore, hopefully...

ya

has joined #pact-node

has joined #pact-node

@ian.mcwilliams has left the channel

has joined #pact-node

has joined #pact-node

hey! I?m trying to run the can-i-deploy tools on my CI environment (Jenkins), and it correctly fails for a newly created consumer pact ``` [2019-05-08T15:22:03.137Z] WARN: pact-node@8.2.0/1208 on 14007e90723d: Pact exited with code 1. [2019-05-08T15:22:03.137Z] ERROR: pact-node@8.2.0/1208 on 14007e90723d: can-i-deploy did not return success message: Computer says no ¯\_(?)_/¯ CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? -------------------------|-----------|--------------|-----------|--------- consumer | d01f352 | provider | ??? | ??? There is no verified pact between version d01f352 of consumer and any version of provider ``` However, the Jenkins step does not actually fail, making me believe the error code is not being thrown

I?ve managed to track down where the logs are printed, but I?m not sure about the error https://github.com/pact-foundation/pact-node/blob/22ead4dc185ec5a5664f81d6b45057f7f2ce3e9a/src/pact-util.ts#L77 https://github.com/pact-foundation/pact-node/blob/22ead4dc185ec5a5664f81d6b45057f7f2ce3e9a/src/can-deploy.ts#L79

any pointers on what could be going on?

hmmm

I?ll have to take a look. I wasn?t across the detail of this implementation, but I know there were some challenges

We?d obviously appreciate any fix if you can get to the bottom of it, but if you need to move quickly you could consider using the CLI tools directly for this purpose: https://github.com/pact-foundation/pact-ruby-standalone/releases

I don?t see a huge benefit in using the JS interface for this sort of thing, but I can see why people use it

You could consider using this docker image if that?s your thing: https://hub.docker.com/r/pactfoundation/pact-cli

yeah, that's a good point. I think there was a light refactor and we lost the ability to exit out with an error code. @rafael.anachoreta are you using the CLI?

sorry, different timezones for us I think :smile: I?m using the pact-node library and running it via node ``` const pact = require('@pact-foundation/pact-node'); const checkProvider = { ... }; pact.canDeploy(checkProvider); ```

What does canDeploy return? E.g. You might want to wrap it in an exit if it returns a rejected promise

yeah it is a promise and catching it works I could throw the exit code from the catch block I guess

I?ll try that and get back to you

:thumbsup:

OK, how do you think it should behave if not rejecting a promise? I?m not sure having it exit is the right thing to do

it does claim to exit with code 1, which got me very confused `[2019-05-08T15:22:03.137Z] WARN: pact-node@8.2.0/1208 on 14007e90723d: Pact exited with code 1.`

ah, that?s the underlying Ruby process. I can see why that might be confusing

These docs (https://github.com/pact-foundation/pact-node/#pact-broker-deployment-check) seem pretty clear to me though

ok so I think my problem was my lack of understanding on how Jenkins handles errors being thrown :thinking_face: I?ve made it so that my node scripts now exit when the promise is rejected and that solved it for me :slightly_smiling_face:

thanks a lot still, do you think it is worth removing the ?exited with code 1? message? I can create an issue

hey, me again :blush: I?m trying to use the can-i-deploy with on a node script, but now I?m having a Promise fail despite the verification passing :thinking_face: ``` [90m [36mcan-i-deploy did not return success message: Computer says yes \o/ CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? -------------------------|-----------|--------------|-------------|--------- consumer | 20c56aa | provider | unspecified | true [32mAll required verification results are published and successful[0m [39m [39mVerification failed! Error: Computer says yes \o/ CONSUMER | C.VERSION | PROVIDER | P.VERSION | SUCCESS? -------------------------|-----------|--------------|-------------|--------- consumer | 20c56aa | provider | unspecified | true [32mAll required verification results are published and successful[0m at ChildProcess.<anonymous> (/home/jenkins/workspace/te-service_iss26703-pact-ci-CULJR5ZNTXCJCA2PK3B4E3S4DS27Z6RXMCODFEKGL4CVV7KK6O4Q/node_modules/@pact-foundation/pact-node/src/can-deploy.js:63:40) at Object.onceWrapper (events.js:317:30) at emitTwo (events.js:131:20) at ChildProcess.emit (events.js:214:7) at maybeClose (internal/child_process.js:925:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:209:5) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```

Here is my `can-i-deploy.js`: ``` const pact = require('@pact-foundation/pact-node'); const { commit } = require('./utils'); const checkProvider = { pactBroker: 'http://my-broker', participant: 'consumer', participantVersion: commit, //gets the commit hash retryWhileUnknown: 5, retryInterval: 10, }; pact.canDeploy(checkProvider).catch(err => { console.error('Verification failed!', err); return process.exit(1); }); ```

What am I missing? Should I file a bug?

More context: https://pact-foundation.slack.com/archives/C9VE9AP9P/p1557329489006300

That certainly looks like a bug to me

I think _this_ PR might be there to address it

Hi @rafael.anachoreta, I?ve pushed out the latest updates to `pact-node` just now. Version `8.3.2` should be out soon

whooo! That did it! :bow: thanks a lot again

:+1: awesome, you're welcome!

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

@sgleadow has left the channel

has joined #pact-node

HI, I am using pact-node version `8.5.0` and looks like my provider api is returning `503 Service Temporarily Unavailable` My code: ```module.exports = (consumer) => { const options = { consumer: 'My consumer', provider: 'My provider', providerBaseUrl: 'https://someqabasepath.mycompany.com', pactBrokerUrl: 'https://myteampactbroker.pact.dius.com.au', providerVersion: '1.0.0', pactBrokerToken: '', validateSSL: false, consumerVersionTag: ['test'], publishVerificationResult: true, }; return new Verifier(options).verifyProvider(); }; ``` When requesting *through postman* the URL `providerBaseUrl + api path` I am getting 200. Am I missing something here?

I believe the providerBaseUrl should be in the form http://localhost:1234 - i.e. pointing to your local system running the pact provider code.

Yes, got it. wonder why it doesn't work using a deployed endpoint...

Also, using versions ``` "@pact-foundation/pact": "^7.0.2", "@pact-foundation/pact-node": "^6.20.0",``` it worked

It should definitely work pointing to a deployed endpoint, but it?s not recommended (when it comes to managing provider states that will be problematic)

And yes, you need the `@pact-foundation/pact` dependency (which uses `@pact-foundation/pact-node` under the hood)

yes, let me rephrase that, using `"@pact-foundation/pact": "^7.0.2"` it works, using `"@pact-foundation/pact": "^8.2.4"` it doesn't work....

This doesn?t sound right. If you enable `DEBUG` logs you should get some more information as to why it?s failing. If it?s a bug we can fix it.

It should definitely be able to talk to an external URL

I will DM you with the logs

thx

has joined #pact-node

has joined #pact-node

Hi @All, i am having a weird issue my query param is around 2588 char length of base65 encoded string some home pact breaks the url query param into two portions and fails my test any idea anyone ?

versions of my package

@pact-foundation/pact: 5.9.1 @pact-foundation/pact-node: 6.19.7

has joined #pact-node

Has anyone seen this issue: ```Error while installing binary: Checksum rejected for file 'pact-1.63.0-osx.tar.gz' with checksum pact-1.63.0-osx.tar.gz.checksum``` I see the same issue happening on linux.

has joined #pact-node

Locally or on CI?

I've seen this when building pact node locally. You need to first compile the typescript project and then you're gold

Not as a consumer of package

It was both locally and CI. I ?fixed? it by deleting package-lock and re-generating it.

:+1:

has joined #pact-node

has joined #pact-node

I?ve been working on trying to setup an initial consumer pact, but I get this after creating the provider every time, ``` [2019-08-15T18:11:01.490Z] ERROR: pact-node@9.0.2/10536 on Chucks-MacBook-Pro.local: Pact Binary Error: /bin/sh: ./standalone/darwin-1.69.0/bin/pact-mock-service: No such file or directory ``` Can?t seem to find any related issues, but I?m running node v10.15.3 and this seems like this is a system issue?

Looks like the install hasn't worked correctly. There should be a binary with that name in node_modules. Can you check to see if it exists somewhere in the folder structure?

Just also confirming (pretty sure it's the case) that you're bit running this in docker?

Just double check the install output of pact-node (dependency of Pact) worked as expected and there were no errors

I am not, just running it locally

I see it in my node modues, but that path perhaps is the issue?

uninstalled everything and now seems to run. Sorry, I should have tried that to begin with. Thank you!

Hehe all good!

Hey All

I am looking for adding support for non http based contracts in Python, I can see that this is already added in node

can someone please share some basic outline on how this is implemented

in the pact file, I do not see reference to provider method, how does provider know which method to call?

Hi Harsh, take a look at https://gist.github.com/bethesque/c858e5c15649ae525ef0cc5264b8477c and diagrams at https://github.com/pact-foundation/pact-message-demo for background

The interaction description is mapped to a function to invoke

has joined #pact-node

Hey guys, Just wanted to gather some thoughts on one of the use case we are trying to solve, any suggestions are much appreciated *Use Case:* We are already using pact to validate api contracts and now want to go one step ahead. The requirement is to check if as part of current release developments, are there any new APIs exposed and if so are there new contract tests written for them. The challenge is to detect if new APIs are written as part feature development and I am looking forward to any suggestions around that. One possible way is to go through all the code changes between previous release and now and get a diff, then run a regex to match pattern e.g. .get('/checkDate',), Looking for any feedback on above approach or if anyone has already solved this use case and can share how to go about it, it will help. Thank you everyone

:tada:

has joined #pact-node

has joined #pact-node

has joined #pact-node

@tjones just going through the pact node stuff and noticed something which has been there a while - should `snyk` be a `devDependency` instead of a runtime one?

I?m guessing the latter, but it?s not. And I think it was the cause (or a transitive cause) of the related pact-js on Node v12 last week

Hm. I'm not sure. `synk` is there because of their auto-PR process - it patches vulnerabilities that haven't been fixed in the packages yet. I think this means it needs to run after the install, so it needs to be a dependency

has joined #pact-node

has joined #pact-node

Is there any particular reason why `snyk` is a runtime dependency for pact-node? It is definitely a devDependency

I asked this same question the other day. I believe it's supposed to be a dev one, but wasn't 100% confident. It's caused some issues recently so want to get it right.

I think it being a runtime dependency means it does some extra magic when installing in a target project (e.g. proxying bad dependencies) but not sure if it's intended to be that way

I can?t think about any use-case why this should be a runtime dependency to be honest? I guess it was just added there by mistake

Good to know. I'll trawl through their docs today and get your PR in if I don't find any contrary evidence

Thank you

There's an issue on JS repo somewhere to track this

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

Hi, just today I have started seeing this error when running Pact tests inside a Docker container - `Pact Binary Error: /bin/sh: 1: ./standalone/linux-x64-1.70.2/bin/pact-mock-service: not found`

Hmmm has something changed? Anything in your install logs which looks spurious?

The thing is I `ls` the path in node_modules/@pact-foundation/pact-node and it exists

Are you running Alpine? If so, check the docs out for it as there are some extra things you need to do

Hey guys I am using a node microservice architecture in GCP with Spanner databases. For running my provider side verification, I need to setup data in my database. I was wondering if I should be using the Spanner or if I should setup a test database like Sqlite and then run all data setup in that test database. I am banking towards setting up a test database but the developers are suggesting me to use Spanner. I can't make up my mind. What do you guys think I should do?

It doesn't matter too much. You should have tests for your repository layer anyway, so it's not about testing your query patterns. If it's simple enough to seed a spanner database in docker, then stick with that. If it's easier to go with sqlite or another in memory db then that's ok.

So go with what's easiest and tests what you need.

Fwiw I tend to stick with a real DB to save developers and testers from learning a new thing. Bit it can depend on how easy is it to swap it out. Does spanner implement a full SQL compatible interface? If not, it's questionable how good the mock is

Spanner does implement a full SQL compatible interface. I was worried about using spanner for the following reasons: 1. Running tests from CI and communicating with a DB that is in GCP would increase my latency 2. It would be difficult to teardown my tests in Spanner because I'd have to delete the database entries I create, in a sqlite I can just destroy the db and create it again when I rerun the tests

What do you mean by having tests for my repository layer? Do you mean having unit tests?

Also when I run my provider verifier in CI, I would have to run my provider server. Would that be wise to do in Jenkins? or should I run the verifier as a job in my kubernetes cluster?

our image is based off ubuntu. i've established that this happens when the tests run twice on the same build agent, so something must not be getting cleaned up

Hey guys I am doing a GET request with a body. My pact file is defined as such: ``` "interactions": [ { "description": "a request to retrieve user account data", "providerState": "it has one user", "request": { "method": "GET", "path": "/account-service/v1.0.0/getAccountInfo", "headers": { "Content-Type": "application/json" }, "body": { "userId": "xxxxx-xxxxx-xxxxx-xxxxx" } }, "response": { "status": 200, "headers": { }, "body": { "phoneNo": xxxxxxxxxxxx, "countryAreaCode": xx } }``` When I am verifying this on the provider side, my GET is not going with a body but is going with a query string: /account-service/v1.0.0/getAccountInfo?%7B%22userId%22%3A%22xxxx-xxxxx-xxxxx-xxxxx%22%7D. Because of this, my code that checks for the schema ['userId': 'xxxx-xxxx-xxxx-xxxx'] is failing as it is not receiving a body. Please verify if this is a bug, I will raise an issue for resolution. :slightly_smiling_face:

Decided on going ahead with a lightweight database like sqlite to reduce the latency that comes as an overhead with using Spanner for CI tests.

Please ignore. Found the issue already logged: https://github.com/pact-foundation/pact-net/issues/185

The error persists on pact-foundation/pact npm package as well.

has joined #pact-node

Hello, I am unable to publish pacts to my pact-broker ```let publisher = require('@pact-foundation/pact-node') let path = require('path') let opts = { pactFilesOrDirs: [path.resolve(process.cwd(), 'pacts')], pactBroker: 'http://spun-up instance', consumerVersion: '2.0.1', } publisher.publishPacts(opts).then(() => console.log('Pacts successfully published'))``` When I run in debug I get less than helpful messages ```C02ZH0DALVCF:bsb-ec-bcp-next-ui john.hamlett$ node .pact/pactPublish.js [2019-11-25T14:32:51.128Z] INFO: pact-node@10.2.2/2416 on C02ZH0DALVCF: Publishing Pacts to Broker [2019-11-25T14:32:51.129Z] INFO: pact-node@10.2.2/2416 on C02ZH0DALVCF: Publishing pacts to broker at: http://mybroker.com [2019-11-25T14:32:51.130Z] DEBUG: pact-node@10.2.2/2416 on C02ZH0DALVCF: Starting pact binary with '/bin/sh,-c,./standalone/darwin-1.72.2/bin/pact-broker publish '/Users/john.hamlett/repos/ecommerce/bsb-ec-bcp-next-ui/pacts' --broker-base-url 'http://mybroker.com' --consumer-app-version '2.0.0',{"cwd":"/Users/john.hamlett/repos/ecommerce/bsb-ec-bcp-next-ui/node_modules/@pact-foundation/pact-node","detached":true,"env":{"TERM_PROGRAM":"vscode","NVM_CD_FLAGS":"","TERM":"xterm-256color","SHELL":"/bin/bash","TMPDIR":"/var/folders/23/33tswn_s2vv5740s88z955bh8ccgb7/T/","Apple_PubSub_Socket_Render":"/private/tmp/com.apple.launchd.SiNUdL0D8F/Render","TERM_PROGRAM_VERSION":"1.41.0-insider","SDKMAN_PLATFORM":"Darwin","NVM_DIR":"/Users/john.hamlett/.nvm","USER":"john.hamlett","SDKMAN_CANDIDATES_API":"https://api.sdkman.io/2","SSH_AUTH_SOCK":"/private/tmp/com.apple.launchd.hNknl19EG7/Listeners","__CF_USER_TEXT_ENCODING":"0x10C63D67:0x0:0x0","PATH":"/Users/john.hamlett/.nvm/versions/node/v13.1.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/john.hamlett/.sdkman/candidates/java/current/bin:/Users/john.hamlett/.nvm/versions/node/v13.1.0/bin","PWD":"/Users/john.hamlett/repos/ecommerce/bsb-ec-bcp-next-ui","JAVA_HOME":"/Users/john.hamlett/.sdkman/candidates/java/current","LANG":"en_US.UTF-8","SDKMAN_VERSION":"5.7.4+362","XPC_FLAGS":"0x0","XPC_SERVICE_NAME":"0","SHLVL":"2","HOME":"/Users/john.hamlett","LOGNAME":"john.hamlett","SDKMAN_DIR":"/Users/john.hamlett/.sdkman","NVM_BIN":"/Users/john.hamlett/.nvm/versions/node/v13.1.0/bin","SDKMAN_CANDIDATES_DIR":"/Users/john.hamlett/.sdkman/candidates","COLORTERM":"truecolor","_":"/Users/john.hamlett/.nvm/versions/node/v13.1.0/bin/node"}}' [2019-11-25T14:32:51.134Z] DEBUG: pact-node@10.2.2/2416 on C02ZH0DALVCF: Created './standalone/darwin-1.72.2/bin/pact-broker publish '/Users/john.hamlett/repos/ecommerce/bsb-ec-bcp-next-ui/pacts' --broker-base-url 'http://mybroker.com' --consumer-app-version '2.0.0'' process with PID: 2417 [2019-11-25T14:32:51.828Z] DEBUG: pact-node@10.2.2/2416 on C02ZH0DALVCF: Publishing bsb-ec-bcp-next-ui/bsb-ec-user-model-service pact to pact broker at http://mybroker.com The latest version of this pact can be accessed at the following URL (use this to configure the provider verification): [2019-11-25T14:32:51.833Z] ERROR: pact-node@10.2.2/2416 on C02ZH0DALVCF: Could not publish pact: Publishing bsb-ec-bcp-next-ui/bsb-ec-user-model-service pact to pact broker at http://mybroker.com The latest version of this pact can be accessed at the following URL (use this to configure the provider verification):``` I did delete the old pact though the UI, is there something else I need to do?

Updating to 9.5.0 for pact seemed to have solved this issue

Looks like the URL isn't coming back from the broker

does the pact appear in the broker after you run this?

No, it does not

Figured it out, seems like I needed to use https not http

Is the space in the broker URL intentional?

Also you can set verbose to true in opts and try, it will help in debugging.

has joined #pact-node

Hi @bethskurrie Is there any chance we can resolve this issue? I cannot change all the implemented GET APIs. The workaround for me will be to write a custom middleware that parses and extracts the body from the query string and then send the GET request with the body. This might not be a very stable way to implement this. Please help :disappointed:

@sankalan13 I'm sorry, the underlying Ruby library does not support GET requests with bodies.

Pact js wraps the underlying pact CLI. If turning on verbose doesn't help, try calling the CLI directly.

I've already had a good look into this, and there's nothing I can do unfortunately.

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

@aaronmckaynz has left the channel

has joined #pact-node

So I tried to fix the tar issue on the train. This build works perfectly locally, but travis is not happy and I?m confused: https://travis-ci.org/pact-foundation/pact-node/jobs/656023906

OK, so on the return ride home, I found the issues with https://pact-foundation.slack.com/archives/C9VE9AP9P/p1582858120001300

Basically, the tests are state dependent - because I had already had the standalone binaries extracted, the piece of code responsible for extracting never fired, so I got a false positive. Going to fix that

Also, as noted by others, I need two libraries - one for .zip and the other for .tar.gz

I have two happish looking builds now: https://travis-ci.org/pact-foundation/pact-node/builds/656129706 and https://ci.appveyor.com/project/pact-foundation/pact-node/builds/31118239 so will re-submit the PR

:+1:

Nice work on a quick fix for this, @matt.fellows!

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

:raised_hands:

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

Is there js library that does this: ```./pact-broker create-version-tag ./pact-broker describe-version```

I don't think so, but quite honestly I'm not sure why I'd use it over the CLI itself. If you didn't notice already, pact node (and therefore pact js) already packages them in their distro, so you can just do `npx pact-broker ...`

It rather confusing to have done tests, publishing, candeploy, verify using js libs and then these 2 are like orphans :slightly_smiling_face:

Fair point.

It wouldn?t be hard to add to the library, feel free to raise an issue/enhancement and somebody will pick it up.

FWIW I see zero value in the JS interface. I?m stuck with an annoying travis issue that is preventing me from removing the last user-facing reference to `pact-node` in examples and standard usage - publishing the contract

But after I do that, the only JS interface 99% of people should be using is Pact JS (`pact`)

Supporting a mirror of the CLI options in JS just seems like unnecessary, duplicitous work and I?ve never really encountered a good reason to have it in JS. I?d be happy to hear more on your case

I?m interested in this! Can you tell me more about what you?ve built that is calling those options directly from javascript?

I?m asking because I tend to think that the best practices should be to use the DSL that pact-js provides for test / verification, then using the binaries directly during CI

I?m worried that the pact-node documentation leads people down the path of implementing their own pact process handlers, which means there?s a lot of work required to get pact up and running, and I don?t think provides much benefit

however, if there?s a clear reason that it?s nicer to call all of this stuff from JS, then I?d like to consider building it all into the DSL

Certainly we could support some stuff in a much nicer way for javascript (eg configuration via package.json)

Hi Tim, all I was saying is that I have commands in Jenkins that just call scripts with information hidden from Jenkinsfile and then you have create-version-tag :)

What does `posttest:pact` look like? Wouldn?t that be the call to the binary? What is stopping you putting the `pact-broker ....` line in as an npm target?

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

Im writing a small programm for a University project. I'd like to test it with the pact framewok. Unfortunately, no Pact.json file is created for me, although there are no errors. My Consumer iss written in Javascript. Below you can see the source code of my javascript file, the console output and my package.json file: ```const {Pact} = require('@pact-foundation/pact'); const axios = require('axios'); const path = require('path'); jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000 describe('Pact Consumer', () => { const provider = new Pact({ consumer: 'consumer', provider: 'producer', port: 1234, cors:true, log: path.resolve(process.cwd(), 'logs', 'pact.log'), dir: path.resolve(process.cwd(), 'pacts'), logLevel: 'INFO', }); beforeAll(() => provider.setup()); describe('consumer', () => { beforeAll ((done) => provider.addInteraction({ uponReceiving: "a request for JSON data", withRequest: { method: "GET", path: "/test", headers: { Accept: "application/json" }, }, willRespondWith: { status: 200, headers: { "Content-Type": "application/json","Access-Control-Allow-Origin": '*' }, body: { name: 'Scherr', surname: 'Valerian', age: 28, }, }, }) .then(done, error => done.fail(error)), ); }); describe('test', () => { it('should return the correct data', () => { axios.get('localhost:8888/test').then(response => { expect(response[0].name).toBe('Scherr'); expect(response[0].surname).toBe('Valerian'); expect(response[0].age).toBe(28); }) }); }); afterEach(() => { provider.verify(); }); afterAll(done => { provider.finalize().then(done, done.fail); }); }); ``` Console output:`"C:\Program Files\nodejs\node.exe" C:\Users\vsche\IdeaProjects\testscenario\webservice\node_modules\jasmine\bin\jasmine.js --reporter=C:\Users\vsche\.IntelliJIdea2019.3\config\plugins\IdeaJasmine\lib\intellij_reporter.js C:/Users/vsche/IdeaProjects/testscenario/webservice/spec/WebService.spec.js --filter=test` [2020-06-08T15:05:38.629Z] INFO: pact-node@10.9.5/8152 on DESKTOP-FH2DU0O: Creating Pact Server with options: {"consumer":"consumer","cors":true,"dir":"C:\\Users\\vsche\\IdeaProjects\\testscenario\\pacts","host":"127.0.0.1","log":"C:\\Users\\vsche\\IdeaProjects\\testscenario\\logs\\pact.log","pactFileWriteMode":"overwrite","port":1234,"provider":"producer","spec":2,"ssl":false} [2020-06-08T15:05:39.679Z] INFO: pact@9.11.0/8152 on DESKTOP-FH2DU0O: Setting up Pact with Consumer "consumer" and Provider "producer" using mock service on Port: "1234" [2020-06-08T15:05:39.700Z] INFO: pact@9.11.0/8152 on DESKTOP-FH2DU0O: Pact File Written [2020-06-08T15:05:39.701Z] INFO: pact-node@10.9.5/8152 on DESKTOP-FH2DU0O: Removing Pact process with PID: 13428 [2020-06-08T15:05:41.800ZPact verification failed!] INFOPopsicleError: Unable to connect to "http://127.0.0.1:1234/interactions" : pact-node@10.9.5/8152 on DESKTOP-FH2DU0O: Caused by: Error: connect ECONNREFUSED 127.0.0.1:1234 Deleting Pact Server with options: {"consumer":"consumer","cors":true,"dir":"C:\\Users\\vsche\\IdeaProjects\\testscenario\\pacts","host":"127.0.0.1","log":"C:\\Users\\vsche\\IdeaProjects\\testscenario\\logs\\pact.log","pactFileWriteMode":"overwrite","port":1234,"provider":"producer","spec":2,"ssl":false} Thanks in advance for any help

I?ve responded on Stack Overflow

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

Hi, I am using Angular 8 and facing issue while downloading pact dependencies. want to know which version is compatible with Angular 8. Thanks.

Well we're going to need more information than that. What's the specific problem?

We don't have any known compatibility problems with angular. It's works with node versions we test against (currently 10 to 14)

It works now after i deleted the node_modules and did the npm install again. Thanks.

Hi All, I am trying to pass query parameter in my withRequest while generating pact but getting regex mismatch error. query: Matchers.term({ generate: 'id=test', matcher: '/id=.*/' }) Not sure how exactly i have to pass matcher value so that it accepts all id's. Please help. Thanks.

Query take an object of key/value pairs, where each key is the name of the param. The value may be a primitive (e.g. test) or a matcher.

has joined #pact-node

has joined #pact-node

Hi, I am trying to install pact-node in Angular App(Angular 8.) My organisation uses a local issuer certificate to fetch the npm packages from their own artifactory using that certificate. I installed karma-pact, pact-web successfully, but the *pact-node* installation is throwing error. Following is a brief log: *Error while installing binary: Postinstalled Failed Unexpectedly: Error downloading binary from https://github.com/pact-foundation/pact-ruby-standalone/releases/download/v1.86.0/pact-1.86.0-win32.zip: Error: Error while installing binary: Error: unable to get local issuer certificate* Basically, it is unable to find the pact-ruby-standalone binary through my company's artifactory. The artifactory is essentially a mirror to git repositories, so ideally there shouldn't be issues. Even so, why is it redirecting to a public address to fetch the binary? Any leads will be of great help. Thanks in advance.

You'll need to install the standalone binary manually

has joined #pact-node

Hi, Is there any @pact-foundation/pact-node that is compatible with Node 4?

Maybe but it would be really old too

Youd have to look at the GitHub release changelog to marry up the Travis releases

has joined #pact-node

has joined #pact-node

has joined #pact-node

Hi there! My name is HeyTaco!, and you can use me to give people tacos to show your appreciation. My tacos will spread joy through Slack!

Hi, Is there any pact-node dependency version compatible with karma 0.13.x?

that seems like a really old version. The current version is 5.1.1 so i?d say if it works it?d be quite lucky. We haven?t tested it so it?s going to depend on the api

Can pact tests be written for angular js projects?

Of course.

Is there something suggesting it can't?

Do we have some examples of angularjs projects available that are using pact?

I know of this library: https://github.com/niklas-wortmann/ngx-pact

But no examples in the wild. Is there something you?re struggling with? There really should be (basically) no angular specific things in your pact tests - aside from the HTTP client that from memory angular provides, the concepts work no matter what UI framework you use

Also, you probably want #pact-js channel (more people, this is really an upstream dependency and you don?t really need to use pact-node directly)

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

@dothetan.040490 has left the channel

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

Hi all :) I am new to Pact.js and after some reading, I found it awesome! exactly the thing we were looking for in the company. We work with NestJS a lot, and I thought that creating an NPM Package that brings those two great technologies together will be nice I would love to hear what you guys think of it! NPM: https://www.npmjs.com/package/nestjs-pact Github: http://www.github.com/omermorad/nestjs-pact

has joined #pact-node

ERROR: pact-node@10.11.1/114876 on W10468KWT2: Pact Binary Error: C:/Users/ruchika_lakhina/Documents/workspace-sts-3.9.9.RELEASE/CloudIQ/ppdd/temp/systems-plugin/node_modules/@pact-foundation/pact-node/standalone/win32-1.88.3/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.6.2/lib/pact/mock_service/cli.rb:5:in `require': cannot load such file -- pact/mock_service/server/wait_for_server_up (LoadError) from C:/Users/ruchika_lakhina/Documents/workspace-sts-3.9.9.RELEASE/CloudIQ/ppdd/temp/systems-plugin/node_modules/@pact-foundation/pact-node/standalone/win32-1.88.3/pact/lib/vendor/ruby/2.2.0/gems/pact-mock_service-3.6.2/lib/pact/mock_service/cli.rb:5:in `<top (required)>' from C:/Users/ruchika_lakhina/Documents/workspace-sts-3.9.9.RELEASE/CloudIQ/ppdd/temp/systems-plugin/node_modules/@pact-foundation/pact-node/standalone/win32-1.88.3/pact/lib/app/pact-mock-service.rb:1:in `require' from C:/Users/ruchika_lakhina/Documents/workspace-sts-3.9.9.RELEASE/CloudIQ/ppdd/temp/systems-plugin/node_modules/@pact-foundation/pact-node/standalone/win32-1.88.3/pact/lib/app/pact-mock-service.rb:1:in `<main>' 24% building 124/126 modules 2 active ...kspace-sts-3.9.9.RELEASE\CloudIQ\ppdd\temp\systems-plugin\src\styles.scss[2021-01-05T14:51:47.199Z] WARN: pact-node@10.11.1/114876 on W10468KWT2: Pact exited with code 1. [2021-01-05T14:51:47.200Z] INFO: pact-node@10.11.1/114876 on W10468KWT2: Removing Pact process with PID: 116500 ERROR: The process "116500" not found. 69% building 784/796 modules 12 active ...gin\src\app\shared\grid\cells\location-cell\location-cell.component.scss05 01 2021 20:22:00.649:ERROR [pact]: Error while trying to run karma-pact: Error: Couldn't start Pact with PID: 116500 I am facing this error while running pact tests. Can someone help me with this?

Looks like the windows long path issue

Look at the GitHub issues for solutions, but simplest is to move your project closer to the root of the drive e.g. `c:/prj`

has joined #pact-node

Thanks ..it worked

has joined #pact-node

has joined #pact-node

hey guys, is there functionality that allows for "OR" matcher e.g. a key value can return either a string || `null`

e.g. `like("key": "string" || null)`

see https://docs.pact.io/faq/#why-is-there-no-support-for-specifying-optional-attributes

has joined #pact-node

has joined #pact-node

has joined #pact-node

has joined #pact-node

does pact only accept certain encoding methods when sending xml through a PACT mock? getting `Encoding::UndefinedConversionError - \"\\xE2\" from ASCII-8BIT to UTF-8` when sending xml with UTF-8

sorry, please ignore this

has joined #pact-node

has joined #pact-node

I have the call at consumer side `api/assets/{assetId}`  where `assetId` is dynamic will be passed from provider side, How do I pass `{assetId}` value from provider side in `nodeJS` project.? can someone share the example ?

Thanks to @dany.marques90 for this fix! :taco: for you!

Thanks a lot for the collaboration @tjones

@bethskurrie ^^

FYI: We?re going to rename `@pact-foundation/pact-node` to `@pact-foundation/pact-core` to better reflect the purpose of the package. No action will be required from users, although if you?re developing tools that depend on `@pact-foundation/pact-node` you will see deprecation warnings until you update to the new package.

I?m archiving this channel to keep all things pact-js in one place. Please join us in either #pact-js or #pact-js-development as appropriate.

archived the channel