nodirbek
2020-08-11 09:41
Guys do you know, if there is a possibility to annotate or tag the generated tests (generated by spring cloud contract verifier)?
matt.fellows
2020-08-11 10:14
I?m not away that you can do it in SCC, but you could easily add it to the metadata section of the JSON document before uploading to the broker
matt.fellows
2020-08-11 10:14
unless you actually mean these tags: https://docs.pact.io/pact_broker/tags#docsNav
heytaco
2020-08-25 03:57
Hi there! My name is HeyTaco!, and you can use me to give people tacos to show your appreciation. My tacos will spread joy through Slack!
marcin.grzejszczak
2021-04-29 07:02
sure, I mean if anyone has any questions I'll be happy to answer them
marcin.grzejszczak
2021-04-29 07:03
BTW I would really love to meet you in person @matt.fellows :slightly_smiling_face: I really regret that I didn't have this opportunity just yet. The whole Pact team does a great job in propagating the contract testing approach. Great work and congratulations.
marcin.grzejszczak
2021-07-19 11:42
FYI the upcoming `3.1.0-M1` Spring Cloud Contract will support Pact `4.1.23` . We can't support Pact `4.2.x` cause its baseline is java11. We should do it for Contract `4.0`.
marcin.grzejszczak
2021-07-19 17:19
Meh, after upgrading to the latest 4.1.x I can't seem to programatically fetch pacts
marcin.grzejszczak
2021-07-19 17:22
I'd really love some help with this. This is the relevant code - https://github.com/spring-cloud/spring-cloud-contract/blob/main/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/stubrunner/PactStubDownloaderBuilder.java#L157-L165 the whole configuration is here https://github.com/spring-cloud/spring-cloud-contract/blob/main/spring-cloud-contract-tools/spring-cloud-contract-pact/src/main/java/org/springframework/cloud/contract/stubrunner/PactStubDownloaderBuilder.java#L232-L358
marcin.grzejszczak
2021-07-19 17:22
this is my consumer that publishes the pact to the broker https://github.com/spring-cloud-samples/spring-cloud-contract-samples/tree/main/consumer_pact
marcin.grzejszczak
2021-07-19 17:23
and this is the producer that can't fetch the pact from the broker https://github.com/spring-cloud-samples/spring-cloud-contract-samples/tree/main/producer_pact - you can just run `./mvnw clean install` in one or the other
marcin.grzejszczak
2021-07-19 17:23
this is the published Pact
```{
"provider": {
"name": "beer-api-producer-pact"
},
"consumer": {
"name": "beer-api-consumer-pact"
},
"interactions": [
{
"_id": "cf7c01f93ae7a216d6f4b6746bb04502b026792a",
"description": "Represents a successful scenario of getting a beer",
"request": {
"method": "POST",
"path": "/check",
"headers": {
"Content-Type": "application/json;charset=UTF-8"
},
"body": {
"name": "marcin",
"age": 25
}
},
"response": {
"status": 200,
"headers": {
"Content-Type": "application/json;charset=UTF-8"
},
"body": {
"status": "OK"
}
},
"providerStates": [
{
"name": ""
}
]
},
{
"_id": "d35b961335e7b04b08d48b8320ecbc26be584136",
"description": "Represents an unsuccessful scenario of getting a beer",
"request": {
"method": "POST",
"path": "/check",
"headers": {
"Content-Type": "application/json;charset=UTF-8"
},
"body": {
"name": "marcin",
"age": 10
}
},
"response": {
"status": 200,
"headers": {
"Content-Type": "application/json;charset=UTF-8"
},
"body": {
"status": "NOT_OK"
}
},
"providerStates": [
{
"name": ""
}
]
}
],
"metadata": {
"pactSpecification": {
"version": "3.0.0"
},
"pact-jvm": {
"version": "4.1.23"
}
}
}```
matt.fellows
2021-07-19 23:05
I?m wondering if the issue is using the tag `latest` (not recommended)
@bethskurrie @uglyog any thoughts? :point_up:
matt.fellows
2021-07-19 23:08
I can see that pacts are being returned, here is the list of them:
``` "pb:pacts": [
{
"href": "http://localhost:8085/pacts/provider/beer-api-producer-pact/consumer/beer-api-consumer-pact/version/0.0.1-SNAPSHOT",
"title": "Pact between beer-api-consumer-pact (0.0.1-SNAPSHOT) and beer-api-producer-pact",
"name": "beer-api-consumer-pact"
}
],```
bethskurrie
2021-07-19 23:10
Using "latest" as a tag name shouldn't break anything, it's just semantically incorrect and potentially confusing.
bethskurrie
2021-07-19 23:12
What's not working @marcin.grzejszczak? The logs seem to show the links to the pacts are being returned as I would expect.
bethskurrie
2021-07-19 23:12
Are you following this? https://github.com/pact-foundation/pact_broker/issues/307
matt.fellows
2021-07-19 23:18
It uses the JVM `PactBrokerLoader` under the hood, so looks to be delegating there
bethskurrie
2021-07-19 23:30
Though, having said that, some versions of pact JVM do seem to have this thing where they use the tag "latest" to mean the overall latest pact (which is not actually a tag).
bethskurrie
2021-07-20 05:52
It's a recent version of the broker :thinking_face: `X-Pact-Broker-Version: 2.80.0`
bethskurrie
2021-07-20 05:55
```{"consumerVersionSelectors":[{"latest":true,"tag":"latest"}],"includePendingStatus":true,"providerVersionTags":["latest"]}```
bethskurrie
2021-07-20 05:55
```{"_embedded":{"pacts":[]},"_links":{"self":{"href":"http://localhost:8085/pacts/provider/beer-api-producer-pact/for-verification","title":"Pacts to be verified"}}}```
bethskurrie
2021-07-20 05:59
Fetching pacts just by tag name isn't really encouraged any more. We use "consumer version selectors" https://docs.pact.io/consumer_version_selectors
bethskurrie
2021-07-20 09:41
when you go to the "view latest tags" link in the broker, what does it show?
marcin.grzejszczak
2021-07-20 09:43
that's what I supsected - I'm changing the code to not pass the tags
bethskurrie
2021-07-20 09:45
so, the jvm had a bit of a funny interface. It (at least it used to) if you put "latest" in the list of tags, it would return the overall latest pact, not the latest pact with the tag "latest".
bethskurrie
2021-07-20 09:46
> Please note that in the Pact Broker (unlike Docker) the term "latest" is not a tag name itself - it's a dynamic reference to the most recently created resource, like "HEAD" in git. The URL `/pacts/provider/{provider}/consumer/{consumer}/latest` refers to pact for the most recently created pacticipant version. The same URL with `/{tag}` appended refers to the pact for the most recently created pacticipant version that has the specified tag. Some Pact-JVM implementations require you to put the key word "latest" in the list of tags for verification when you want the overall latest pact. This is just an implementation choice of that particular client, and does not mean that there is or should be a tag called "latest". Please do not use the tag "latest" or you will get very confused when talking about the "latest latest pact", which would have a URL of `/pacts/provider/Bar/consumer/Foo/latest/latest`!
bethskurrie
2021-07-20 09:49
The new way to get the overall latest pact is to use the selector `{"latest": true}`
bethskurrie
2021-07-20 09:50
There are a bunch of selectors, and a few new ones will be added soon. You probably don't want to have to update your code each time, so if you're able to just allow arbitrary maps, it will make your life much easier.
bethskurrie
2021-07-20 09:51
Great. I'm about to raise an issue in all of the pact broker client libraries with this text, which will be relevant for you too.
bethskurrie
2021-07-20 09:51
> Add support for new consumer version selector keys
>
> Please add support for the following keys to be used in the consumer version selectors when fetching pacts for verification:
>
> ```
> { "deployed": true }
>
> { "released": true }
>
> { "environment": "<env name>" }
>
> { "deployed": true}
>
> { "released": true}
>
> { "deployedOrReleased": true }
> ```
>
> These keys can be used in various combinations ( eg. `{ "environment": "prod", released: true, consumer: "Foo" }` ). Please allow any combination of keys, and do not validate them locally, as the validation rules can change over time as support is added for new selectors - just ensure that any validation error returned from the API is shown clearly to the user.
>
> See https://github.com/pact-foundation/pact_broker/blob/master/lib/pact_broker/doc/views/provider-pacts-for-verification.markdown for the usage docs of each selector.
>
> As more selectors will be added over time, it's my preference that the consumer version selectors are not strongly typed, and are just passed through straight from the configuration object to the API, so that we don't have to make code changes to the Pact clients each time we add new selectors. (eg. there will be a new tag regex matching selector coming sometime). I understand that this is not compatible with the idioms of every Pact client language however, so do whatever you need to do to make the new selectors work elegantly within your language.
>
> Please update https://docs.pact.io/pact_broker/advanced_topics/consumer_version_selectors/ for your language once the selectors have been released.
